Add --sum option to interface-usage mode

ChangeLog

@@ -1,3 +1,97 @@
+* 2019-02-18 7.5
+  add Draytek Vigor
+* 2019-01-09 7.4.3
+  add mode interface-security (cisco)
+* 2018-12-17 7.4.2.1
+  finish ha-status for cisco wlc
+* 2018-12-12 7.4.2
+  start ha for cisco wlc
+  improve paloalto uptime model string
+  improve ucd memory
+* 2018-12-04 7.4.1.2
+  fix cisco bgp for routers which do not export the proptietary mib, but bgp4
+* 2018-12-04 7.4.1.1
+  fix undefs for Huawei with older Mibs
+  fix fortigate sensors
+* 2018-12-04 7.4.1
+  detect more Huawei devices
+* 2018-12-03 7.4
+  use proprietary bgp mib for cisco (and add ipv6)
+  make ospd v6-ready
+  add servertpe generic_ucd
+  fix ciscoipsecflow fail timestamps
+* 2018-10-22 7.3.1
+  add modes ha-status/role for fortigate
+* 2018-10-22 7.3.0.5
+  update glplugin (CISCO-STACKWISE-MIB)
+* 2018-10-21 7.3.0.4
+  update glplugin (for go-worker)
+* 2018-10-17 7.3.0.3
+  update glplugin
+  better fortigate detection
+* 2018-09-28 7.3.0.2
+  update glplugin
+* 2018-09-25 7.3.0.1
+  re-enable Huawei CloudEngine support
+* 2018-09-10 7.3
+  update stack-status
+  add servertype hostresource
+  update cisco vpn-status
+* 2018-08-13 7.2.0.2
+  bugfix in interface-modes where --name3 found no match
+* 2018-08-10 7.2.0.1
+  bugfix in ios ha-status, ignore cable "failover" description
+* 2018-08-01 7.2
+  add packet forwarding engine metrics for juniper standby nodes
+* 2018-07-26 7.1
+  add custom thresholds for cisco ccm
+  detect fritzbox 7490
+* 2018-07-13 7.0.2
+  add interface-uptime
+ 2018-07-05 7.0.1.6
+  fix a bug in non-map FabOS memory
+  set thresholds to 100% for cisco asa heapcache memory-usage
+* 2018-06-18 7.0.1.5
+  update glplugin (get_snmp_table_objects waja fix)
+* 2018-05-05 7.0.1.4
+  simplify the cisco memory exceptions
+* 2018-04-29 7.0.1.3
+  bugfix in cisco global shared memory > 9.3.2
+* 2018-03-31 7.0.1.2
+  fix a bug in link-aggregation-availability
+* 2018-03-13 7.0.1.1
+  fix a bug in cisco enhanced mempool mib and posixmem (thx sabedevops)
+* 2018-03-07 7.0.1
+  improve f5, add ha-role, check-config, count-connections
+* 2018-03-01 7.0.0.7
+  update GLPlugin
+* 2018-02-26 7.0.0.6
+  ignore free space of iso mounts in hostresource mib
+* 2018-02-06 7.0.0.5
+  fix a bug in hostresourcesmib memory calc. (arista eos)
+* 2018-02-08 7.0.0.5
+  update glplugn, add modes encode/decode, rfc3986
+* 2018-01-23 7.0.0.4
+  merge pull request #164 (simonmeggle)
+  add bluecoat asg fix from Stefan Kublik
+* 2018-01-12 7.0.0.3
+  check the clock of checkpoint fw
+* 2018-01-11 7.0.0.2
+  fix a bug in checkpoint vpn-status
+* 2018-01-08 7.0.0.1
+  update glplugin
+* 2018-01-05 7.0
+  code improvements, fix hh3c entities
+* 2017-12-27 6.4.4.1
+  fix f5 versions
+* 2017-12-21 6.4.4
+  add interface-duplex
+* 2017-12-15 6.4.3.3
+  fix a bug in vsx-firewall1-fork
+* 2017-12-14 6.4.3.2
+  update glplugin
+* 2017-12-14 6.4.3.1
+  update glplugin
 * 2017-12-12 6.4.3
   add checkpoint ha-status, fix checkpoint vpn-status
 * 2017-11-27 6.4.2.3

README.md

@@ -1,8 +1,12 @@
+Meet me at...
+=============
+<div><a href="https://monitors2019.consol.de/wiki/doku.php?id=workshop:2019:start" target="_blank"><img src="https://labs.consol.de/assets/images/muenchen-banner.png" alt="Monitoring-Workshop 2019" style="height: auto !important;width: auto !important;" ></a></div>
+
 Description
 ============
 The plugin check_nwc_health was developed with the aim of having a single tool for all aspects of monitoring of network components.
 
-<a href="https://labs.consol.de/wiki/doku.php?id=workshop:2017:start"><img src="https://labs.consol.de/assets/images/duesseldorf-banner.gif"></a>
+<div><a href="https://www.buymeacoffee.com/bsNED0Wct" target="_blank"><img src="https://www.buymeacoffee.com/assets/img/custom_images/black_img.png" alt="Buy Me A Coffee" style="height: auto !important;width: auto !important;" ></a></div>
 
 Motivation
 ==========
@@ -24,23 +28,23 @@ Modi
 | Mode                          | Function                                                               |
 |-------------------------------|------------------------------------------------------------------------|
 | hardware-health               | Check the status of environmental equipment (fans, temperatures, power) |
-| cpu-load                      | Check the CPU load of the device) |
-| memory-usage                  | Check the memory usage of the device) |
-| interface-usage               | Check the utilization of interfaces) |
+| cpu-load                      | Check the CPU load of the device |
+| memory-usage                  | Check the memory usage of the device |
+| interface-usage               | Check the utilization of interfaces |
 | interface-errors              | Check the error-rate of interfaces  |
-| interface-discards            | Check the discard-rate of interfaces) |
+| interface-discards            | Check the discard-rate of interfaces |
 | interface-status              | Check the status of interfaces (oper/admin) |
-| interface-nat-count-sessions  | Count the number of nat sessions) |
+| interface-nat-count-sessions  | Count the number of nat sessions |
 | interface-nat-rejects         | Count the number of nat sessions rejected due to lack of resources) |
-| list-interfaces               | Show the interfaces of the device and update the name cache) |
-| list-interfaces-detail        | Show the interfaces of the device and some details) |
+| list-interfaces               | Show the interfaces of the device and update the name cache |
+| list-interfaces-detail        | Show the interfaces of the device and some details |
 | interface-availability        | Show the availability (oper != up of interfaces) |
-| link-aggregation-availability | Check the percentage of up interfaces in a link aggregation) |
-| list-routes                   | Check the percentage of up interfaces in a link aggregation) |
-| route-exists                  | Check if a route exists. --name is the dest, --name2 check also the next hop)) |
-| count-routes                  | Count the routes. --name is the dest, --name2 is the hop)) |
-| vpn-status                    | Check the status of vpns (up/down)) |
-| create-shinken-service        | Create a Shinken service definition) |
+| link-aggregation-availability | Check the percentage of up interfaces in a link aggregation |
+| list-routes                   | Check the percentage of up interfaces in a link aggregation |
+| route-exists                  | Check if a route exists. (--name is the dest, --name2 check also the next hop) |
+| count-routes                  | Count the routes. (--name is the dest, --name2 is the hop) |
+| vpn-status                    | Check the status of vpns (up/down) |
+| create-shinken-service        | Create a Shinken service definition |
 | hsrp-state                    | Check the state in a HSRP group) |
 | hsrp-failover                 | Check if a HSRP group's nodes have changed their roles |
 | list-hsrp-groups              | Show the HSRP groups configured on this device |
@@ -60,7 +64,7 @@ Modi
 | pool-complections             | Check the members and connections of a load balancer pool |
 | list-pools                    | List load balancer pools |
 | check-licenses                | Check the installed licences/keys |
-| count-users                   | Count the | connected) users/sessions |
+| count-users                   | Count the (connected) users/sessions |
 | check-config                  | Check the status of configs (cisco, unsaved config changes) |
 | check-connections             | Check the quality of connections |
 | count-connections             | Check the number of connections (-client, -server is possible) |

configure.ac

@@ -1,7 +1,7 @@
 dnl Process this file with autoconf to produce a configure script.
 AC_REVISION ($Revision: 1.150 $)
 AC_PREREQ(2.58)
-AC_INIT(check_nwc_health,6.4.3)
+AC_INIT(check_nwc_health,7.5)
 AM_INIT_AUTOMAKE([1.9 tar-pax])
 AM_MAINTAINER_MODE([disable])
 AC_CANONICAL_HOST

plugins-scripts/Classes/ALARMMIB/Component/AlarmSubsystem.pm

@@ -3,7 +3,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::Item);
 use strict;
 
 sub init {
-  my $self = shift;
+  my ($self) = @_;
   $self->get_snmp_tables('ALARM-MIB', [
       #['models', 'alarmModelTable', 'Classes::ALARMMIB::Component::AlarmSubsystem::AlarmModel'],
       #['variables', 'alarmActiveVariableTable', 'Classes::ALARMMIB::Component::AlarmSubsystem::AlarmVariable'],
@@ -26,7 +26,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::TableItem);
 use strict;
 
 sub finish {
-  my $self = shift;
+  my ($self) = @_;
   $self->{ceAlarmTypes} = [];
   if ($self->{alarmActiveVariableValueType} eq 'octetString') {
     my $index = 0;
@@ -44,7 +44,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::TableItem);
 use strict;
 
 sub check {
-  my $self = shift;
+  my ($self) = @_;
   $self->add_info(sprintf "there are %d active alarms",
       $self->{alarmActiveStatsActiveCurrent});
   if ($self->{alarmActiveStatsActiveCurrent}) {

plugins-scripts/Classes/AVOS.pm

@@ -3,7 +3,7 @@ our @ISA = qw(Classes::Bluecoat);
 use strict;
 
 sub init {
-  my $self = shift;
+  my ($self) = @_;
   if ($self->mode =~ /device::hardware::health/) {
   } elsif ($self->mode =~ /device::hardware::load/) {
     $self->analyze_and_check_cpu_subsystem("Classes::AVOS::Component::CpuSubsystem");

plugins-scripts/Classes/AVOS/Component/ConnectionSubsystem.pm

@@ -3,13 +3,13 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::Item);
 use strict;
 
 sub init {
-  my $self = shift;
+  my ($self) = @_;
   $self->get_snmp_objects('BLUECOAT-AV-MIB', (qw(
       avSlowICAPConnections)));
 }
 
 sub check {
-  my $self = shift;
+  my ($self) = @_;
   $self->add_info(sprintf '%d slow ICAP connections',
       $self->{avSlowICAPConnections});
   $self->set_thresholds(warning => 100, critical => 100);

plugins-scripts/Classes/AVOS/Component/CpuSubsystem.pm

@@ -3,8 +3,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::Item);
 use strict;
 
 sub init {
-  my $self = shift;
-  my %params = @_;
+  my ($self, %params) = @_;
   # With AVOS version 5.5.4.1, 5.4.6.1 and 6.1.2.1, the SNMP MIB has been extended to support multiple CPU cores.
   # The new OID is defined as a table 1.3.6.1.4.1.3417.2.11.2.4.1 in the BLUECOAT-SG-PROXY-MIB file with the following sub-OIDs.
   # https://kb.bluecoat.com/index?page=content&id=FAQ1244&actp=search&viewlocale=en_US&searchid=1360452047002
@@ -23,7 +22,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::TableItem);
 use strict;
 
 sub check {
-  my $self = shift;
+  my ($self) = @_;
   $self->add_info(sprintf 'cpu %s usage is %.2f%%',
       $self->{sgProxyCpuCoreIndex}, $self->{sgProxyCpuCoreBusyPerCent});
   $self->set_thresholds(warning => 80, critical => 90);
@@ -41,7 +40,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::TableItem);
 use strict;
 
 sub check {
-  my $self = shift;
+  my ($self) = @_;
   $self->add_info(sprintf 'cpu %s usage is %.2f%%',
       $self->{deviceUsageIndex}, $self->{deviceUsagePercent});
   $self->set_thresholds(warning => $self->{deviceUsageHigh} - 10, critical => $self->{deviceUsageHigh});

plugins-scripts/Classes/AVOS/Component/KeySubsystem.pm

@@ -3,13 +3,13 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::Item);
 use strict;
 
 sub init {
-  my $self = shift;
+  my ($self) = @_;
   $self->get_snmp_objects('BLUECOAT-AV-MIB', (qw(
       avLicenseDaysRemaining avVendorName)));
 }
 
 sub check {
-  my $self = shift;
+  my ($self) = @_;
   $self->add_info(sprintf 'license %s expires in %d days',
       $self->{avVendorName},
       $self->{avLicenseDaysRemaining});

plugins-scripts/Classes/AVOS/Component/MemSubsystem.pm

@@ -9,7 +9,7 @@ sub init {
   # There's two separate OIDs to obtain memory pressure value for AVOSV4 and AVOSV5;
   # AVOSV4:  memPressureValue - OIDs: 1.3.6.1.4.1.3417.2.8.2.3 (systemResourceMIB)
   # AVOSV5: sgProxyMemoryPressure - OIDs: 1.3.6.1.4.1.3417.2.11.2.3.4 (bluecoatSGProxyMIB)
-  my $self = shift;
+  my ($self) = @_;
   $self->get_snmp_objects('BLUECOAT-SG-PROXY-MIB', (qw(
       sgProxyMemPressure sgProxyMemAvailable sgProxyMemCacheUsage sgProxyMemSysUsage)));
   if (! defined $self->{sgProxyMemPressure}) {
@@ -36,7 +36,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::Item);
 use strict;
 
 sub check {
-  my $self = shift;
+  my ($self) = @_;
   my $errorfound = 0;
   $self->add_info('checking memory');
   $self->add_info(sprintf 'memory usage is %.2f%%',

plugins-scripts/Classes/AVOS/Component/SecuritySubsystem.pm

@@ -3,13 +3,13 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::Item);
 use strict;
 
 sub init {
-  my $self = shift;
+  my ($self) = @_;
   $self->get_snmp_objects('BLUECOAT-AV-MIB', (qw(
       avVirusesDetected)));
 }
 
 sub check {
-  my $self = shift;
+  my ($self) = @_;
   $self->add_info(sprintf '%d viruses detected',
       $self->{avVirusesDetected});
   $self->set_thresholds(warning => 1500, critical => 1500);

plugins-scripts/Classes/Alcatel.pm

@@ -3,7 +3,7 @@ our @ISA = qw(Classes::Device);
 use strict;
 
 sub init {
-  my $self = shift;
+  my ($self) = @_;
   if ($self->{productname} =~ /AOS.*OAW/i) {
     bless $self, 'Classes::Alcatel::OmniAccess';
     $self->debug('using Classes::Alcatel::OmniAccess');

plugins-scripts/Classes/Alcatel/OmniAccess.pm

@@ -3,7 +3,7 @@ our @ISA = qw(Classes::Alcatel);
 use strict;
 
 sub init {
-  my $self = shift;
+  my ($self) = @_;
   if ($self->mode =~ /device::hardware::health/) {
     $self->analyze_and_check_environmental_subsystem("Classes::Alcatel::OmniAccess::Component::EnvironmentalSubsystem");
     # waere praktischer, aber in diesem fall muss alarmdreck ausgeputzt werden

plugins-scripts/Classes/Alcatel/OmniAccess/Component/CpuSubsystem.pm

@@ -3,7 +3,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::Item);
 use strict;
 
 sub init {
-  my $self = shift;
+  my ($self) = @_;
   $self->get_snmp_tables('WLSX-SYSTEMEXT-MIB', [
       ['memories', 'wlsxSysExtProcessorTable', 'Classes::Alcatel::OmniAccess::Component::CpuSubsystem::Cpu'],
   ]);
@@ -15,7 +15,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::TableItem);
 use strict;
 
 sub check {
-  my $self = shift;
+  my ($self) = @_;
   my $label = sprintf '%s_usage', lc $self->{sysExtProcessorDescr};
   $label =~ s/\s+/_/g;
   $self->add_info(sprintf '%s usage is %.2f%%',

plugins-scripts/Classes/Alcatel/OmniAccess/Component/EnvironmentalSubsystem.pm

@@ -3,7 +3,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::Item);
 use strict;
 
 sub init {
-  my $self = shift;
+  my ($self) = @_;
   $self->{fan_subsystem} =
       Classes::Alcatel::OmniAccess::Component::FanSubsystem->new();
   $self->get_snmp_objects('WLSX-SYSTEMEXT-MIB', qw(
@@ -15,7 +15,7 @@ sub init {
 }
 
 sub check {
-  my $self = shift;
+  my ($self) = @_;
   $self->{fan_subsystem}->check();
   $self->{powersupply_subsystem}->check();
   $self->{storage_subsystem}->check();
@@ -32,7 +32,7 @@ sub check {
 }
 
 sub dump {
-  my $self = shift;
+  my ($self) = @_;
   printf "[%s]\n%s\n", uc "wlsxSysExtInternalTemparature", 
       $self->{wlsxSysExtInternalTemparature};
   $self->{fan_subsystem}->dump();

plugins-scripts/Classes/Alcatel/OmniAccess/Component/FanSubsystem.pm

@@ -3,7 +3,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::Item);
 use strict;
 
 sub init {
-  my $self = shift;
+  my ($self) = @_;
   $self->get_snmp_tables('WLSX-SYSTEMEXT-MIB', [
       ['fans', 'wlsxSysExtFanTable', 'Classes::Alcatel::OmniAccess::Component::FanSubsystem::Fan'],
   ]);
@@ -14,7 +14,7 @@ our @ISA = qw(Monitoring::GLPlugin::SNMP::TableItem);
 use strict;
 
 sub check {
-  my $self = shift;
+  my ($self) = @_;
   $self->add_info(sprintf 'fan %d status is %s',
       $self->{flat_indices},
       $self->{sysExtFanStatus});

plugins-scripts/Classes/Alcatel/OmniAccess/Component/HaSubsystem.pm

@@ -4,7 +4,7 @@ use strict;
 use constant { OK => 0, WARNING => 1, CRITICAL => 2, UNKNOWN => 3 };
 
 sub init {
-  my $self = shift;
+  my ($self) = @_;
   if ($self->mode =~ /device::ha::role/) {
     $self->get_snmp_objects('WLSX-SYSTEMEXT-MIB', (qw(wlsxSysExtSwitchRole)));
     if (! $self->opts->role()) {
@@ -14,7 +14,7 @@ sub init {
 }
 
 sub check {
-  my $self = shift;
+  my ($self) = @_;
   $self->add_info('checking ha');
   $self->add_info(sprintf 'ha role is %s', $self->{wlsxSysExtSwitchRole});
   if ($self->{wlsxSysExtSwitchRole} ne $self->opts->role()) {