Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prework for multiple chargers per cs #1480

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Prework for multiple chargers per cs #1480

wants to merge 16 commits into from

Conversation

drc38
Copy link
Collaborator

@drc38 drc38 commented Jan 9, 2025

@lbbrhzn still a bit of work but appreciate your views on the draft.

Maintains current functionality ie 1 charger per cs but tidies up the code and will make it easier to implement multiple chargers per cs in the future.

@drc38 drc38 temporarily deployed to continuous-integration January 9, 2025 20:52 — with GitHub Actions Inactive
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 95.58824% with 9 lines in your changes missing coverage. Please review.

Project coverage is 94.31%. Comparing base (6e5a419) to head (5fb4b05).

Files with missing lines Patch % Lines
custom_components/ocpp/api.py 96.20% 3 Missing ⚠️
custom_components/ocpp/config_flow.py 92.00% 2 Missing ⚠️
custom_components/ocpp/ocppv16.py 86.66% 2 Missing ⚠️
custom_components/ocpp/__init__.py 95.65% 1 Missing ⚠️
custom_components/ocpp/chargepoint.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1480      +/-   ##
==========================================
- Coverage   94.69%   94.31%   -0.38%     
==========================================
  Files          12       12              
  Lines        1943     2042      +99     
==========================================
+ Hits         1840     1926      +86     
- Misses        103      116      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drc38 drc38 temporarily deployed to continuous-integration January 10, 2025 23:52 — with GitHub Actions Inactive
@drc38 drc38 temporarily deployed to continuous-integration January 11, 2025 03:00 — with GitHub Actions Inactive
@drc38 drc38 temporarily deployed to continuous-integration January 11, 2025 03:04 — with GitHub Actions Inactive
@drc38 drc38 temporarily deployed to continuous-integration January 11, 2025 19:37 — with GitHub Actions Inactive
@drc38 drc38 changed the title Allow multiple chargers per cs Prework for multiple chargers per cs Jan 11, 2025
@drc38 drc38 marked this pull request as ready for review January 11, 2025 20:14
@drc38 drc38 temporarily deployed to continuous-integration January 12, 2025 21:30 — with GitHub Actions Inactive
@drc38
Copy link
Collaborator Author

drc38 commented Jan 12, 2025

A release with these changes is available here: https://github.com/drc38/ocpp/releases/tag/0.8.1

@drc38 drc38 temporarily deployed to continuous-integration January 12, 2025 21:56 — with GitHub Actions Inactive
@drc38 drc38 temporarily deployed to continuous-integration January 12, 2025 22:34 — with GitHub Actions Inactive
@drc38 drc38 temporarily deployed to continuous-integration January 13, 2025 00:03 — with GitHub Actions Inactive
@drc38 drc38 had a problem deploying to continuous-integration January 13, 2025 05:18 — with GitHub Actions Failure
@drc38
Copy link
Collaborator Author

drc38 commented Jan 13, 2025

@drc38 drc38 temporarily deployed to continuous-integration January 13, 2025 05:25 — with GitHub Actions Inactive
@drc38 drc38 temporarily deployed to continuous-integration January 13, 2025 09:44 — with GitHub Actions Inactive
@drc38
Copy link
Collaborator Author

drc38 commented Jan 13, 2025

@drc38 drc38 temporarily deployed to continuous-integration January 14, 2025 06:52 — with GitHub Actions Inactive
@drc38 drc38 temporarily deployed to continuous-integration January 14, 2025 09:27 — with GitHub Actions Inactive
@drc38 drc38 temporarily deployed to continuous-integration January 16, 2025 02:48 — with GitHub Actions Inactive
@drc38 drc38 deployed to continuous-integration January 16, 2025 02:58 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant