Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(RingTheory/Artinian): IsUnit a iff a ∈ R⁰ for an artinian ring R #21084

Closed
wants to merge 2 commits into from

Conversation

mistarro
Copy link
Collaborator


Open in Gitpod

Copy link

github-actions bot commented Jan 26, 2025

PR summary aab53147e3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ isUnit_iff_mem_nonZeroDivisors
+ isUnit_of_mem_nonZeroDivisors
+ isUnit_submonoid_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 26, 2025
@mistarro mistarro added the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 26, 2025
Mathlib/RingTheory/Artinian/Ring.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Artinian/Ring.lean Outdated Show resolved Hide resolved
@mistarro
Copy link
Collaborator Author

Removed _of_artinian suffix as it is in IsArtinianRing namespace.

@mistarro mistarro force-pushed the mistarro/artinian-isunit-nonzerodivisor branch from 984b56c to aab5314 Compare January 26, 2025 13:11
@mistarro mistarro changed the title feat(RingTheory/Artinian): IsUnit a iff a ∈ nonZeroDivisors R for an artinian ring R feat(RingTheory/Artinian): IsUnit a iff a ∈ R⁰ for an artinian ring R Jan 26, 2025
@erdOne
Copy link
Member

erdOne commented Jan 26, 2025

Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 27, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 27, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Artinian): IsUnit a iff a ∈ R⁰ for an artinian ring R [Merged by Bors] - feat(RingTheory/Artinian): IsUnit a iff a ∈ R⁰ for an artinian ring R Jan 27, 2025
@mathlib-bors mathlib-bors bot closed this Jan 27, 2025
@mathlib-bors mathlib-bors bot deleted the mistarro/artinian-isunit-nonzerodivisor branch January 27, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants