-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: norm_num
extension for Real.sqrt
and NNReal.sqrt
#21102
base: master
Are you sure you want to change the base?
Conversation
PR summary 9c84c42927Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
#9915 is a rotting attempt to fix this. |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This PR introduces a
norm_num
extension for bothReal.sqrt
andNNReal.sqrt
. While the version forReal.sqrt
can handle both integers and rationals, the version forNNReal.sqrt
can only deal with integers, due to a limitation of norm_num (i.e. theIsRat
type requires aRing
instance).I put the extension directly in
Data/Real/Sqrt
, but I could put them in a separate file inTactic/NormNum
if this is deemed better. (The obvious downside is that potential users would need to import the file explicitly.)