fix tasks

learning-process · Jan 19, 2025 · 442ac45 · 442ac45
1 parent 728f00f
commit 442ac45
Show file tree

Hide file tree

Showing 31 changed files with 172 additions and 190 deletions.
diff --git a/modules/core/perf/func_tests/test_task.hpp b/modules/core/perf/func_tests/test_task.hpp
@@ -1,7 +1,4 @@
-#ifndef MODULES_CORE_TESTS_TEST_TASK_HPP_
-#define MODULES_CORE_TESTS_TEST_TASK_HPP_
-
-#include <gtest/gtest.h>
+#pragma once
 
 #include <memory>
 #include <thread>
@@ -16,7 +13,7 @@ namespace ppc::test::perf {
 template <class T>
 class TestTask : public ppc::core::Task {
  public:
-  explicit TestTask(ppc::core::TaskDataPtr task_data) : Task(task_data) {}
+  explicit TestTask(const ppc::core::TaskDataPtr &task_data) : Task(task_data) {}
 
   bool PreProcessingImpl() override {
     input_ = reinterpret_cast<T *>(task_data->inputs[0]);
@@ -53,5 +50,3 @@ class FakePerfTask : public TestTask<T> {
 };
 
 }  // namespace ppc::test::perf
-
-#endif  // MODULES_CORE_TESTS_TEST_TASK_HPP_
diff --git a/modules/core/perf/include/perf.hpp b/modules/core/perf/include/perf.hpp
@@ -1,10 +1,8 @@
-#ifndef MODULES_CORE_INCLUDE_PERF_HPP_
-#define MODULES_CORE_INCLUDE_PERF_HPP_
+#pragma once
 
 #include <cstdint>
 #include <functional>
 #include <memory>
-#include <vector>
 
 #include "core/task/include/task.hpp"
 
@@ -13,14 +11,14 @@ namespace ppc::core {
 struct PerfAttr {
   // count of task's running
   uint64_t num_running;
-  std::function<double(void)> current_timer = [&] { return 0.0; };
+  std::function<double()> current_timer = [&] { return 0.0; };
 };
 
 struct PerfResults {
   // measurement of task's time (in seconds)
   double time_sec = 0.0;
   enum TypeOfRunning : uint8_t { kPipeline, kTaskRun, kNone } type_of_running = kNone;
-  constexpr const static double kMaxTime = 10.0;
+  constexpr static double kMaxTime = 10.0;
 };
 
 class Perf {
@@ -32,19 +30,16 @@ class Perf {
   void SetTask(const std::shared_ptr<Task>& task_ptr);
   // Check performance of full task's pipeline:  PreProcessing() ->
   // Validation() -> Run() -> PostProcessing()
-  void PipelineRun(const std::shared_ptr<PerfAttr>& perf_attr,
-                   const std::shared_ptr<ppc::core::PerfResults>& perf_results);
+  void PipelineRun(const std::shared_ptr<PerfAttr>& perf_attr, const std::shared_ptr<PerfResults>& perf_results) const;
   // Check performance of task's Run() function
-  void TaskRun(const std::shared_ptr<PerfAttr>& perf_attr, const std::shared_ptr<ppc::core::PerfResults>& perf_results);
+  void TaskRun(const std::shared_ptr<PerfAttr>& perf_attr, const std::shared_ptr<PerfResults>& perf_results) const;
   // Pint results for automation checkers
   static void PrintPerfStatistic(const std::shared_ptr<PerfResults>& perf_results);
 
  private:
   std::shared_ptr<Task> task_;
   static void CommonRun(const std::shared_ptr<PerfAttr>& perf_attr, const std::function<void()>& pipeline,
-                        const std::shared_ptr<ppc::core::PerfResults>& perf_results);
+                        const std::shared_ptr<PerfResults>& perf_results);
 };
 
 }  // namespace ppc::core
-
-#endif  // MODULES_CORE_INCLUDE_PERF_HPP_
diff --git a/modules/core/perf/src/perf.cpp b/modules/core/perf/src/perf.cpp
@@ -5,7 +5,6 @@
 #include <iomanip>
 #include <iostream>
 #include <sstream>
-#include <utility>
 
 ppc::core::Perf::Perf(const std::shared_ptr<Task>& task_ptr) { SetTask(task_ptr); }
 
@@ -15,7 +14,7 @@ void ppc::core::Perf::SetTask(const std::shared_ptr<Task>& task_ptr) {
 }
 
 void ppc::core::Perf::PipelineRun(const std::shared_ptr<PerfAttr>& perf_attr,
-                                  const std::shared_ptr<ppc::core::PerfResults>& perf_results) {
+                                  const std::shared_ptr<ppc::core::PerfResults>& perf_results) const {
   perf_results->type_of_running = PerfResults::TypeOfRunning::kPipeline;
 
   CommonRun(
@@ -30,7 +29,7 @@ void ppc::core::Perf::PipelineRun(const std::shared_ptr<PerfAttr>& perf_attr,
 }
 
 void ppc::core::Perf::TaskRun(const std::shared_ptr<PerfAttr>& perf_attr,
-                              const std::shared_ptr<ppc::core::PerfResults>& perf_results) {
+                              const std::shared_ptr<ppc::core::PerfResults>& perf_results) const {
   perf_results->type_of_running = PerfResults::TypeOfRunning::kTaskRun;
 
   task_->Validation();

diff --git a/modules/core/task/func_tests/test_task.hpp b/modules/core/task/func_tests/test_task.hpp
@@ -1,9 +1,5 @@
-#ifndef MODULES_CORE_TESTS_TEST_TASK_HPP_
-#define MODULES_CORE_TESTS_TEST_TASK_HPP_
+#pragma once
 
-#include <gtest/gtest.h>
-
-#include <memory>
 #include <vector>
 
 #include "core/task/include/task.hpp"
@@ -13,7 +9,7 @@ namespace ppc::test::task {
 template <class T>
 class TestTask : public ppc::core::Task {
  public:
-  explicit TestTask(ppc::core::TaskDataPtr task_data) : Task(task_data) {}
+  explicit TestTask(const ppc::core::TaskDataPtr &task_data) : Task(task_data) {}
   bool PreProcessingImpl() override {
     input_ = reinterpret_cast<T *>(task_data->inputs[0]);
     output_ = reinterpret_cast<T *>(task_data->outputs[0]);
@@ -38,5 +34,3 @@ class TestTask : public ppc::core::Task {
 };
 
 }  // namespace ppc::test::task
-
-#endif  // MODULES_CORE_TESTS_TEST_TASK_HPP_
diff --git a/modules/core/task/include/task.hpp b/modules/core/task/include/task.hpp
@@ -3,7 +3,6 @@
 #include <chrono>
 #include <cstdint>
 #include <filesystem>
-#include <iostream>
 #include <memory>
 #include <string>
 #include <vector>

diff --git a/modules/core/util/util.hpp b/modules/core/util/util.hpp
@@ -1,12 +1,14 @@
 #pragma once
 
-#include <chrono>
+#ifdef _WIN32
 #include <cstdint>
-#include <filesystem>
 #include <iostream>
 #include <memory>
-#include <string>
 #include <vector>
+#endif
+
+#include <filesystem>
+#include <string>
 
 namespace ppc::util {
 

diff --git a/tasks/all/example/func_tests/func_all.cpp b/tasks/all/example/func_tests/func_all.cpp
@@ -7,14 +7,14 @@
 #include "core/util/util.hpp"
 
 TEST(nesterov_a_test_task_all, test_matmul_50) {
-  const size_t count = 50;
+  constexpr size_t kCount = 50;
 
   // Create data
-  std::vector<int> in(count * count, 0);
-  std::vector<int> out(count * count, 0);
+  std::vector<int> in(kCount * kCount, 0);
+  std::vector<int> out(kCount * kCount, 0);
 
-  for (size_t i = 0; i < count; i++) {
-    in[(i * count) + i] = 1;
+  for (size_t i = 0; i < kCount; i++) {
+    in[(i * kCount) + i] = 1;
   }
 
   // Create task_data

diff --git a/tasks/all/example/include/ops_all.hpp b/tasks/all/example/include/ops_all.hpp
@@ -1,10 +1,9 @@
 #pragma once
 
-#include <tbb/tbb.h>
+#include <oneapi/tbb.h>
 
 #include <boost/mpi/collectives.hpp>
 #include <boost/mpi/communicator.hpp>
-#include <string>
 #include <vector>
 
 #include "core/task/include/task.hpp"

diff --git a/tasks/all/example/perf_tests/perf_all.cpp b/tasks/all/example/perf_tests/perf_all.cpp
@@ -1,20 +1,19 @@
 #include <gtest/gtest.h>
 
-#include <boost/mpi/timer.hpp>
 #include <vector>
 
 #include "all/example/include/ops_all.hpp"
 #include "core/perf/include/perf.hpp"
 
 TEST(nesterov_a_test_task_all, test_pipeline_run) {
-  const int count = 900;
+  constexpr int kCount = 900;
 
   // Create data
-  std::vector<int> in(count * count, 0);
-  std::vector<int> out(count * count, 0);
+  std::vector<int> in(kCount * kCount, 0);
+  std::vector<int> out(kCount * kCount, 0);
 
-  for (size_t i = 0; i < count; i++) {
-    in[(i * count) + i] = 1;
+  for (size_t i = 0; i < kCount; i++) {
+    in[(i * kCount) + i] = 1;
   }
 
   // Create task_data
@@ -52,14 +51,14 @@ TEST(nesterov_a_test_task_all, test_pipeline_run) {
 }
 
 TEST(nesterov_a_test_task_all, test_task_run) {
-  const int count = 900;
+  constexpr int kCount = 900;
 
   // Create data
-  std::vector<int> in(count * count, 0);
-  std::vector<int> out(count * count, 0);
+  std::vector<int> in(kCount * kCount, 0);
+  std::vector<int> out(kCount * kCount, 0);
 
-  for (size_t i = 0; i < count; i++) {
-    in[(i * count) + i] = 1;
+  for (size_t i = 0; i < kCount; i++) {
+    in[(i * kCount) + i] = 1;
   }
 
   // Create task_data

diff --git a/tasks/all/example/src/ops_all.cpp b/tasks/all/example/src/ops_all.cpp
@@ -9,21 +9,13 @@ namespace {
 void MatMul(const std::vector<int> &in_vec, int rc_size, std::vector<int> &out_vec) {
   for (int i = 0; i < rc_size; ++i) {
     for (int j = 0; j < rc_size; ++j) {
+      out_vec[(i * rc_size) + j] = 0;
       for (int k = 0; k < rc_size; ++k) {
         out_vec[(i * rc_size) + j] += in_vec[(i * rc_size) + k] * in_vec[(k * rc_size) + j];
       }
     }
   }
 }
-void MatMulElse(const std::vector<int> &in_vec, int rc_size, std::vector<int> &out_vec) {
-  for (int k = 0; k < rc_size; ++k) {
-    for (int j = 0; j < rc_size; ++j) {
-      for (int i = 0; i < rc_size; ++i) {
-        out_vec[(i * rc_size) + j] += in_vec[(i * rc_size) + k] * in_vec[(k * rc_size) + j];
-      }
-    }
-  }
-}
 }  // namespace
 
 bool nesterov_a_test_task_all::TestTaskALL::PreProcessingImpl() {
@@ -46,8 +38,11 @@ bool nesterov_a_test_task_all::TestTaskALL::ValidationImpl() {
 
 bool nesterov_a_test_task_all::TestTaskALL::RunImpl() {
   if (world_.rank() == 0) {
-#pragma omp parallel
-    { MatMul(input_, rc_size_, output_); }
+#pragma omp parallel default(none)
+    {
+#pragma omp critical
+      { MatMul(input_, rc_size_, output_); }
+    }
   } else if (world_.rank() == 1) {
     const int num_threads = ppc::util::GetPPCNumThreads();
     std::vector<std::thread> threads(num_threads);
@@ -56,10 +51,16 @@ bool nesterov_a_test_task_all::TestTaskALL::RunImpl() {
       threads[i].join();
     }
   } else if (world_.rank() == 2) {
-    oneapi::tbb::task_arena arena;
-    arena.execute([&] { MatMul(input_, rc_size_, output_); });
+    oneapi::tbb::task_arena arena(1);
+    arena.execute([&] {
+      tbb::task_group tg;
+      for (int i = 0; i < ppc::util::GetPPCNumThreads(); ++i) {
+        tg.run([&] { MatMul(input_, rc_size_, output_); });
+      }
+      tg.wait();
+    });
   } else {
-    MatMulElse(input_, rc_size_, output_);
+    MatMul(input_, rc_size_, output_);
   }
   world_.barrier();
   return true;

diff --git a/tasks/mpi/example/func_tests/main.cpp b/tasks/mpi/example/func_tests/main.cpp
@@ -7,14 +7,14 @@
 #include "mpi/example/include/ops_mpi.hpp"
 
 TEST(nesterov_a_test_task_mpi, test_matmul_50) {
-  const size_t count = 50;
+  constexpr size_t kCount = 50;
 
   // Create data
-  std::vector<int> in(count * count, 0);
-  std::vector<int> out(count * count, 0);
+  std::vector<int> in(kCount * kCount, 0);
+  std::vector<int> out(kCount * kCount, 0);
 
-  for (size_t i = 0; i < count; i++) {
-    in[(i * count) + i] = 1;
+  for (size_t i = 0; i < kCount; i++) {
+    in[(i * kCount) + i] = 1;
   }
 
   // Create task_data

diff --git a/tasks/mpi/example/include/ops_mpi.hpp b/tasks/mpi/example/include/ops_mpi.hpp
@@ -5,8 +5,6 @@
 #include <boost/mpi/collectives.hpp>
 #include <boost/mpi/communicator.hpp>
 #include <memory>
-#include <numeric>
-#include <string>
 #include <utility>
 #include <vector>
 

diff --git a/tasks/mpi/example/perf_tests/main.cpp b/tasks/mpi/example/perf_tests/main.cpp
@@ -1,20 +1,19 @@
 #include <gtest/gtest.h>
 
-#include <boost/mpi/timer.hpp>
 #include <vector>
 
 #include "core/perf/include/perf.hpp"
 #include "mpi/example/include/ops_mpi.hpp"
 
 TEST(nesterov_a_test_task_mpi, test_pipeline_run) {
-  const int count = 500;
+  constexpr int kCount = 500;
 
   // Create data
-  std::vector<int> in(count * count, 0);
-  std::vector<int> out(count * count, 0);
+  std::vector<int> in(kCount * kCount, 0);
+  std::vector<int> out(kCount * kCount, 0);
 
-  for (size_t i = 0; i < count; i++) {
-    in[(i * count) + i] = 1;
+  for (size_t i = 0; i < kCount; i++) {
+    in[(i * kCount) + i] = 1;
   }
 
   // Create task_data
@@ -52,14 +51,14 @@ TEST(nesterov_a_test_task_mpi, test_pipeline_run) {
 }
 
 TEST(nesterov_a_test_task_mpi, test_task_run) {
-  const int count = 500;
+  constexpr int kCount = 500;
 
   // Create data
-  std::vector<int> in(count * count, 0);
-  std::vector<int> out(count * count, 0);
+  std::vector<int> in(kCount * kCount, 0);
+  std::vector<int> out(kCount * kCount, 0);
 
-  for (size_t i = 0; i < count; i++) {
-    in[(i * count) + i] = 1;
+  for (size_t i = 0; i < kCount; i++) {
+    in[(i * kCount) + i] = 1;
   }
 
   // Create task_data

diff --git a/tasks/omp/example/func_tests/main.cpp b/tasks/omp/example/func_tests/main.cpp
@@ -7,14 +7,14 @@
 #include "omp/example/include/ops_omp.hpp"
 
 TEST(nesterov_a_test_task_omp, test_matmul_50) {
-  const size_t count = 50;
+  constexpr size_t kCount = 50;
 
   // Create data
-  std::vector<int> in(count * count, 0);
-  std::vector<int> out(count * count, 0);
+  std::vector<int> in(kCount * kCount, 0);
+  std::vector<int> out(kCount * kCount, 0);
 
-  for (size_t i = 0; i < count; i++) {
-    in[(i * count) + i] = 1;
+  for (size_t i = 0; i < kCount; i++) {
+    in[(i * kCount) + i] = 1;
   }
 
   // Create task_data

diff --git a/tasks/omp/example/include/ops_omp.hpp b/tasks/omp/example/include/ops_omp.hpp
@@ -1,6 +1,5 @@
 #pragma once
 
-#include <string>
 #include <vector>
 
 #include "core/task/include/task.hpp"