Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slave stack - various fixes and start unit tests #191

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

leducp
Copy link
Owner

@leducp leducp commented Dec 11, 2024

Fix: od_generator: memory data type shall be enforced
Fix: mailbox response: CoE: SDO Info: ED response put the object name, not the entry description
Fix: mailbox response: CoE: SDO CA: buffer overflow
Fix: mailbox response: CoE: SDO CA: wrong size if access start at SI1
Fix: mailbox response: CoE: SDO CA: header malformed
Fix: EsiParser: bit offset is not properly parsed, leading to wrong SDO CA response.
coverage: exclude final hardware implementation wich cannot be unit tested
unit test: start response tests

Philippe Leduc added 2 commits December 9, 2024 17:43
Copy link

github-actions bot commented Dec 11, 2024

File Coverage Lines Branches
All files 40% 47% 34%
lib/include/kickcat/Error.h 87% 92% 83%
lib/include/kickcat/Mailbox.h 91% 100% 83%
lib/include/kickcat/Ring.h 0% 0% 0%
lib/include/kickcat/SBufQueue.h 0% 0% 0%
lib/include/kickcat/Units.h 0% 0% 0%
lib/include/kickcat/protocol.h 62% 62% 0%
lib/include/kickcat/CoE/EsiParser.h 0% 0% 0%
lib/include/kickcat/CoE/OD.h 50% 50% 0%
lib/include/kickcat/CoE/mailbox/request.h 66% 66% 0%
lib/include/kickcat/CoE/mailbox/response.h 33% 33% 0%
lib/master/include/kickcat/Bus.h 63% 100% 27%
lib/master/include/kickcat/DebugHelpers.h 83% 100% 66%
lib/master/include/kickcat/Gateway.h 75% 100% 50%
lib/master/include/kickcat/Link.h 92% 85% 100%
lib/master/src/Bus.cc 81% 85% 77%
lib/master/src/CoE.cc 84% 95% 74%
lib/master/src/Link.cc 98% 100% 97%
lib/master/src/Prints.cc 48% 39% 58%
lib/master/src/Slave.cc 50% 50% 0%
lib/master/src/helpers.cc 0% 0% 0%
lib/slave/include/kickcat/AbstractESC.h 50% 50% 0%
lib/slave/include/kickcat/ESC/EmulatedESC.h 0% 0% 0%
lib/slave/include/kickcat/ESC/Lan9252.h 0% 0% 0%
lib/slave/include/kickcat/ESC/XMC4800.h 0% 0% 0%
lib/slave/src/AbstractESC.cc 0% 0% 0%
lib/slave/src/AbstractEmulatedEEPROM.cc 0% 0% 0%
lib/slave/src/AbstractSPI.cc 0% 0% 0%
lib/slave/src/EEPROM/EEPROM_factory.cc 0% 0% 0%
lib/slave/src/ESC/EmulatedESC.cc 0% 0% 0%
lib/slave/src/ESC/Lan9252.cc 0% 0% 0%
lib/slave/src/ESC/XMC4800.cc 0% 0% 0%
lib/src/Error.cc 0% 0% 0%
lib/src/Frame.cc 85% 92% 77%
lib/src/Mailbox.cc 43% 54% 32%
lib/src/SIIParser.cc 93% 95% 91%
lib/src/TapSocket.cc 0% 0% 0%
lib/src/protocol.cc 75% 76% 74%
lib/src/CoE/EsiParser.cc 0% 0% 0%
lib/src/CoE/OD.cc 10% 18% 3%
lib/src/CoE/protocol.cc 30% 41% 18%
lib/src/CoE/mailbox/request.cc 54% 57% 52%
lib/src/CoE/mailbox/response.cc 23% 28% 18%
simulation/network_simulator.cc 0% 0% 0%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 68f6753

@leducp leducp force-pushed the slave_stack_coverage_1 branch from 4e5aeaf to 68f6753 Compare December 11, 2024 16:03
@leducp leducp merged commit 2907afd into master Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants