-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let DataLoader
default setters overwrite (not append) + lgdo.Struct.int_dtype
#493
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
==========================================
+ Coverage 48.42% 48.47% +0.04%
==========================================
Files 104 104
Lines 12461 12498 +37
==========================================
+ Hits 6034 6058 +24
- Misses 6427 6440 +13
☔ View full report in Codecov by Sentry. |
Could you add a test of the |
DataLoader
default setters overwrite (not append) + lgdo.Struct.int_dtype
key_dtype
to the Struct attributes so that we can use non-strings as keys in Struct. Converts to/from string when writing to/from disk. Also returns the output ofdl.load(merge_files=False)
as a Struct now that ints can be used as keys.append
argument in case appending is the desired behavior.Addresses #492 first point