Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the latest legend-pydataobj and dspeed versions #522

Merged
merged 7 commits into from
Jan 2, 2024

Conversation

MoritzNeuberger
Copy link
Contributor

The update of the import references according to legend-exp/legend-pydataobj#24

@gipert
Copy link
Member

gipert commented Oct 30, 2023

We'll also need to update the legend-pydataobj version bound in pyproject.toml, once a new version is released.

@gipert gipert marked this pull request as draft November 2, 2023 14:13
@gipert gipert added the dependencies Pull requests that update a dependency file label Jan 1, 2024
@gipert gipert marked this pull request as ready for review January 2, 2024 16:38
@gipert gipert changed the title Updated lh5_store import references after refactor Support the latest legend-pydataobj and dspeed versions Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (10798dc) 18.28% compared to head (646cf1a) 18.25%.

Files Patch % Lines
src/pygama/flow/data_loader.py 53.33% 7 Missing ⚠️
src/pygama/pargen/energy_optimisation.py 16.66% 5 Missing ⚠️
src/pygama/pargen/extract_tau.py 0.00% 3 Missing ⚠️
src/pygama/flow/file_db.py 87.50% 2 Missing ⚠️
src/pygama/pargen/utils.py 0.00% 2 Missing ⚠️
src/pygama/pargen/AoE_cal.py 0.00% 1 Missing ⚠️
src/pygama/pargen/ecal_th.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   18.28%   18.25%   -0.04%     
==========================================
  Files          33       33              
  Lines        7165     7167       +2     
==========================================
- Hits         1310     1308       -2     
- Misses       5855     5859       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert
Copy link
Member

gipert commented Jan 2, 2024

Why CI keeps failing is really a mystery to me. I'm trying to reach the tqdm developers here: tqdm/tqdm#1037

I will go ahead and merge for now.

@gipert gipert merged commit 0adfdc2 into legend-exp:main Jan 2, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants