Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math refactor and pargen updates #545

Merged
merged 222 commits into from
Apr 27, 2024
Merged

math refactor and pargen updates #545

merged 222 commits into from
Apr 27, 2024

Conversation

gipert
Copy link
Member

@gipert gipert commented Jan 12, 2024

No description provided.

@gipert gipert marked this pull request as ready for review April 26, 2024 14:11
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 44.01232% with 1454 lines in your changes are missing coverage. Please review.

Project coverage is 50.05%. Comparing base (e7b7b36) to head (7950c34).

Files Patch % Lines
src/pygama/pargen/data_cleaning.py 26.07% 360 Missing ⚠️
src/pygama/pargen/dsp_optimize.py 0.00% 299 Missing ⚠️
src/pygama/pargen/energy_optimisation.py 4.19% 160 Missing ⚠️
src/pygama/pargen/extract_tau.py 0.00% 102 Missing ⚠️
src/pygama/pargen/dplms_ge_dict.py 0.00% 56 Missing ⚠️
src/pygama/math/histogram.py 65.16% 54 Missing ⚠️
src/pygama/math/hpge_peak_fitting.py 65.32% 43 Missing ⚠️
src/pygama/math/functions/exgauss.py 54.65% 39 Missing ⚠️
src/pygama/math/functions/sum_dists.py 83.81% 39 Missing ⚠️
src/pygama/pargen/lq_cal.py 25.00% 39 Missing ⚠️
... and 19 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #545       +/-   ##
===========================================
+ Coverage   21.34%   50.05%   +28.71%     
===========================================
  Files          42       63       +21     
  Lines        7907     7581      -326     
===========================================
+ Hits         1688     3795     +2107     
+ Misses       6219     3786     -2433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasondet
Copy link
Collaborator

Sam fixed the errors -- I'm going to merge!

@jasondet jasondet merged commit daa9530 into main Apr 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
math Statistics/mathematics pargen Generation of analysis parameters (calibrations etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants