-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DPZ extractor to pargen #558
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
==========================================
+ Coverage 22.82% 25.51% +2.68%
==========================================
Files 42 42
Lines 8110 8220 +110
==========================================
+ Hits 1851 2097 +246
+ Misses 6259 6123 -136 ☔ View full report in Codecov by Sentry. |
@ggmarshall @SamuelBorden can this be merged to main or will mess up with the refactor? |
I need to change some imports from the energy cal routines, but then it should be good to go. I'll work on synergizing this with the pargen refactor |
Can this be closed? Supplanted by #596 ? |
The function
get_dpz_decay_constants
works to get the constants needed for the double pole zero filter in three steps:This is a first pass at the routine, so we should think maybe a bit more about where to put this in the dataflow. Right now this quickly interfaces with the single pole-zero dataflow script; to do that, the superpulse is created inside the function
get_dpz_decay_constants
. But we might want to makeget_dpz_decay_constants
a bit more general and instead create the superpulse in the dataflow.There are other issues currently with the double pole zero filter, see legend-exp/dspeed#52. So I am going to mark this as a draft PR