Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged in main to refactor, fixed merge conflicts #563

Merged
merged 229 commits into from
Mar 8, 2024

Conversation

SamuelBorden
Copy link
Collaborator

I merged in main and fixed the merge conflicts I had created by changing some imports in pargen. Now pargen is restored to how it is in main currently, and is ready for the E_cal refactor.

MoritzNeuberger and others added 30 commits October 30, 2023 11:21
…ior on tail to remove degeneracy, added check on guess so no guess params are none, bounded mu to be in fit range, improved validity checks
…rations, wrote resolution fitting to include both linear and quadratic fits, changed results output for clarity
… of results, split out plots into own functions
…ed get_pulser_ids to get_tcm_pulser_ids, added ability to return mask for load_data
Increase legend-pydataobj lower version bound
Defines a general class that contains the different functions used during the calibration process, in a similar manner to AoE_cal.py. A few plotting functions are redundant with those found in AoE_cal.py. We should consider generalizing some of these plotting functions in the future for other PSD parameters.
ggmarshall and others added 25 commits February 2, 2024 16:32
bugfix for pargen load_data to eval all fields in hit dict, specify dtype when init lh5 objects in evt and support subtables in skm
bugfix for load_data put run timestamp in later
Allow `build_evt()` and `build_skm()` to just return the output table
…acing `nan`s (legend-exp#559)

* fixed bug in cast_triger where awk arrays not replacing nans
Bump legend-pydataobj version and ignore Pandas/Pyarrow deprecation warning
* [docs] add draft CITATION.cff

---------

Co-authored-by: Jason Detwiler <jasondet@gmail.com>
Update citation-related documentation
@SamuelBorden SamuelBorden changed the title Merged in main, fixed merge conflicts Merged in main to refactor, fixed merge conflicts Mar 7, 2024
@gipert gipert marked this pull request as ready for review March 8, 2024 15:42
@gipert gipert added the pargen Generation of analysis parameters (calibrations etc.) label Mar 8, 2024
@gipert gipert merged commit c37ed84 into legend-exp:refactor Mar 8, 2024
4 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pargen Generation of analysis parameters (calibrations etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants