-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged in main to refactor, fixed merge conflicts #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ior on tail to remove degeneracy, added check on guess so no guess params are none, bounded mu to be in fit range, improved validity checks
…rations, wrote resolution fitting to include both linear and quadratic fits, changed results output for clarity
… of results, split out plots into own functions
…ernal to main function
…ed get_pulser_ids to get_tcm_pulser_ids, added ability to return mask for load_data
…entiate from normal timestamp
A/E and calibration changes
legend-exp#523) pre-compute col_tiers for speedup
Increase legend-pydataobj lower version bound
Defines a general class that contains the different functions used during the calibration process, in a similar manner to AoE_cal.py. A few plotting functions are redundant with those found in AoE_cal.py. We should consider generalizing some of these plotting functions in the future for other PSD parameters.
bugfix for pargen load_data to eval all fields in hit dict, specify dtype when init lh5 objects in evt and support subtables in skm
bugfix for load_data put run timestamp in later
Allow `build_evt()` and `build_skm()` to just return the output table
…acing `nan`s (legend-exp#559) * fixed bug in cast_triger where awk arrays not replacing nans
Bump legend-pydataobj version and ignore Pandas/Pyarrow deprecation warning
* [docs] add draft CITATION.cff --------- Co-authored-by: Jason Detwiler <jasondet@gmail.com>
Update citation-related documentation
SamuelBorden
changed the title
Merged in main, fixed merge conflicts
Merged in main to refactor, fixed merge conflicts
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged in main and fixed the merge conflicts I had created by changing some imports in pargen. Now pargen is restored to how it is in main currently, and is ready for the E_cal refactor.