Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

physics: increase default time threshold for decays #160

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

ManuelHu
Copy link
Collaborator

as it was before geant4 11.2...

This avoids confusion and unforseen breakage. Also the higher threshold makes sense for most of our simulations?

what do you think @gipert @tdixon97 ?

see also #135 #158

@tdixon97
Copy link
Collaborator

I think its a good idea but we should probably work out what time difference can be resolvable by double with the necessarily precision (idk 1 us). I think this is probably around 30,000 yrs (ie roughly 17 digits for double).
Then we should give an error or warning if the user requests a simulation with an intermediate step having dt > this.

@ManuelHu ManuelHu force-pushed the lifetime-threshold branch 2 times, most recently from 98ca6a9 to f8670c4 Compare November 13, 2024 12:05
@ManuelHu ManuelHu changed the title physics: increase default time threshold for decays (1 year -> 1e60 years) physics: increase default time threshold for decays Nov 13, 2024
@ManuelHu
Copy link
Collaborator Author

the old default was actually 1e27 ns (~twice the age of the universe), and not 1e60 years.

back to the old default of Geant4 11.0 - 11.1
@gipert gipert linked an issue Dec 2, 2024 that may be closed by this pull request
@ManuelHu ManuelHu merged commit 99ebf7a into legend-exp:main Dec 2, 2024
6 checks passed
@ManuelHu ManuelHu deleted the lifetime-threshold branch December 2, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Times for decay chains / killed nuclei
2 participants