Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust examples to the new detector handling #165

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

EricMEsch
Copy link
Collaborator

The recent updates that moved the

    enum DetectorType {
      kGermanium,
      kOptical,
      kScintillator,
    };

Out of RMGHardware broke the examples and the custom written c++ code, as the enum is now no longer part of the RMGHardware class. This went past the tests, as there is no extra compiled code in the tests.

I am not sure if the rest of the way the registration should be handled is still the same, but this works. Compile tested but did not check the output.

@ManuelHu
Copy link
Collaborator

I am not sure if the rest of the way the registration should be handled is still the same, but this works. Compile tested but did not check the output.

should have stayed the same. The naming has only been changed to break a circular dependency... (and the "typical" way to break that is impossible: one cannot forward declare nested structs/enums; thanks C++)

@ManuelHu ManuelHu merged commit e5b0f3f into legend-exp:main Nov 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants