-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vis label to all tests opening a GUI #229
Conversation
@gipert is there no way to prevent a GUI being produced?
…________________________________
From: Eric Esch ***@***.***>
Sent: Thursday, January 16, 2025 5:59 PM
To: legend-exp/remage ***@***.***>
Cc: Dixon, Toby ***@***.***>; Review requested ***@***.***>
Subject: Re: [legend-exp/remage] Add vis label to all tests opening a GUI (PR #229)
⚠ Caution: External sender
@EricMEsch<https://github.com/EricMEsch> requested your review on: #229<#229> Add vis label to all tests opening a GUI.
—
Reply to this email directly, view it on GitHub<#229 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANSET45E3MAUWFPLAQDQL3L2K7QOHAVCNFSM6AAAAABVKCOCTOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHE3DIOBSGU2TCNI>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
There certainly is, it depends on what you actually want the tests to do. You could force tcsh similar to how its done in the |
I would gues this will not change much, at least for the tests. The test are not interactive; so this would not change anything for them...
probably not, at least no nice one in the current framework and without removing our test output. The tests use Xorg-based visualization, and probably there is no way to turn the window off with that. You can only fully disable visualization, but then you also do not get the rendered PDF output files. Some tips for @EricMEsch :
and for us all:
|
Another related issue is that many visulisation plots do not get rendered properly when run in CI, I am not sure why... any idea @ManuelHu . |
@ManuelHu these tips could go in the dev guide... |
@ManuelHu thanks for the tipps, |
Some of the tests added did not have the "vis" label although they opened a GUI. When i run tests localy inside of the apptainer container that use the OGL GUI they brick my screen, which means i typically have to restart the computer, so I typically run
ctest -LE vis
. I am sure there is some way to fix my local issue, but i think also the labels should be applied correctly ;)