-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- CCA now correctly requires positive targets - CCorA now correctly requires targets - All estimators (other than `RawKNNRegressor`) now explicitly prohibit sparse data. This is a temporary measure to fix failing checks. A closer investigation of sparse support is needed. - The addition of `target_tags.required` to CCorA triggered an estimator check `check_requires_y_none` which looks for an expected error message when passed `y=None`. That error is now correctly raised by passing y into `_validate_data`. This removed the need to separately check the y array. Note that we don't mutate `X` with the validation check as this will strip feature names that must be passed to `StandardScalerWithDOF`.
- Loading branch information
Showing
3 changed files
with
15 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters