Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Mode Editing bug fixed #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aigoncharov
Copy link

If a user made some changes in the source mode the model will update only upon clicking the source mode button

@Yvem
Copy link
Contributor

Yvem commented Jan 4, 2016

Hello and thanks !

can you elaborate a little bit on what the problem is and how can I reproduce it ?

And / or could you add tests ?

@l0c0luke
Copy link

l0c0luke commented Feb 5, 2016

i see this as well but i thought it was a wysiwyg problem?

if you modify the content of the wysiwyg while viewing the source ... the underlying model doesnt change... you have to click the source button again, to go back to visual mode, then the model gets updated

@human33
Copy link

human33 commented Jun 1, 2016

i see this as well but i thought it was a wysiwyg problem?

if you modify the content of the wysiwyg while viewing the source ... the underlying model doesnt change... you have to click the source button again, to go back to visual mode, then the model gets updated

It because model updates on events require change focus. If you click somewhere else model updates too.

@human33
Copy link

human33 commented Jun 1, 2016

Hello and thanks !

can you elaborate a little bit on what the problem is and how can I reproduce it ?

  1. show model used for editor somewhere else
  2. edit text
  3. model not changed until you click somewhere for change focus

@Orlicek
Copy link

Orlicek commented Jun 17, 2016

+1

@JBustin JBustin self-assigned this Nov 2, 2016
@JBustin
Copy link

JBustin commented Nov 2, 2016

@l0c0luke @human--
I couldn't reproduce.
Do you have still the problem ?
A plunker to illustrate ?

@FreeFly19
Copy link

Have the same issue, please accept the commit...

Conflicts:
	angular-ckeditor.min.js
	angular-ckeditor.min.map
	bower.json
	package.json
@aigoncharov
Copy link
Author

@JBustin Here's a plunkr that demonstrates the issue https://plnkr.co/edit/ZTNJXJA7GsTKlBMjRPio?p=preview

Try typing something in, an alert with updated model is going to show up only after you click 'Source' again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants