-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass CKEditor instance on ready callback #46
base: master
Are you sure you want to change the base?
Conversation
…ready(). This also updates the angular model on the selection change and paste events.
The ability to get the CKEditor instance in the provided Is this something that is likely to be merged? Thanks! |
@@ -41,7 +41,7 @@ | |||
// Initialize the editor content when it is ready. | |||
controller.ready().then(function initialize() { | |||
// Sync view on specific events. | |||
['dataReady', 'change', 'blur', 'saveSnapshot'].forEach(function (event) { | |||
['dataReady', 'change', 'blur', 'saveSnapshot', 'selectionChange', 'paste'].forEach(function (event) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why model should be sync on selectionChange event ?
@mckoon |
@JBustin - I think you mentioned me by mistake; this PR is from @MicahFulton not me. Thanks |
when will the changes be merged on the master. I am waiting for this fix eagerly. |
@MicahFulton |
@JBustin Can you please merge the changes on master asap. I need this change urgently or else I will have to create a separate directive just with this change.. |
This solves issue #37