Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: Update quick smol agent config and prompt #23

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

leonvanbokhorst
Copy link
Owner

@leonvanbokhorst leonvanbokhorst commented Jan 7, 2025

  • Changed the authorized imports to include "math" for enhanced functionality.
  • Increased the planning interval from 1 to 3 and max iterations from 5 to 20, allowing for more complex story generation.
  • Updated the story prompt from "Find a way to escape from the matrix." to "How many apples go in a tiny bushel?" to diversify the narrative focus.

These adjustments improve the agent's capability in generating varied and intricate stories.

Summary by Sourcery

Update the quick smol agent to use "math" imports, increase the planning interval to 3, increase the maximum iterations to 20, and change the story prompt to "How many apples go in a tiny bushel?".

New Features:

  • Authorize the use of the "math" module.

Enhancements:

  • Increase the planning interval from 1 to 3 and the maximum iterations from 5 to 20 to allow for more complex story generation.

- Changed the authorized imports to include "math" for enhanced functionality.
- Increased the planning interval from 1 to 3 and max iterations from 5 to 20, allowing for more complex story generation.
- Updated the story prompt from "Find a way to escape from the matrix." to "How many apples go in a tiny bushel?" to diversify the narrative focus.

These adjustments improve the agent's capability in generating varied and intricate stories.
Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request updates the story generation parameters and prompt to enhance the agent's storytelling capabilities by allowing more complex and diverse narratives.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated authorized imports
  • Added "math" to the additional_authorized_imports list.
  • Removed commented-out imports "requests" and "random".
src/smol_agents/quick_smol.py
Modified story generation parameters
  • Increased planning_interval from 1 to 3.
  • Increased max_iterations from 5 to 20.
src/smol_agents/quick_smol.py
Changed story prompt
  • Updated the prompt from "Find a way to escape from the matrix." to "How many apples go in a tiny bushel?".
src/smol_agents/quick_smol.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@leonvanbokhorst leonvanbokhorst changed the title feat(quick_smol): Update story generation parameters and prompt @sourcery-ai Jan 7, 2025
@leonvanbokhorst leonvanbokhorst self-assigned this Jan 7, 2025
@leonvanbokhorst leonvanbokhorst added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 7, 2025
@sourcery-ai sourcery-ai bot changed the title @sourcery-ai Enhance: Update quick smol agent config and prompt Jan 7, 2025
@leonvanbokhorst leonvanbokhorst added this to the Benchmarking milestone Jan 7, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leonvanbokhorst - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide justification for the parameter changes (planning_interval=3, max_iterations=20) and include performance benchmarks comparing old and new values.
  • The removal of 'requests' and 'random' imports in favor of 'math' needs explanation. How does this change benefit story generation?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@leonvanbokhorst leonvanbokhorst merged commit 2667e23 into main Jan 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant