Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade axum to v0.8 #3439

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: upgrade axum to v0.8 #3439

wants to merge 4 commits into from

Conversation

sabify
Copy link
Contributor

@sabify sabify commented Jan 3, 2025

No description provided.

@sabify
Copy link
Contributor Author

sabify commented Jan 3, 2025

Are the failed CIs related to this PR?

@gbj
Copy link
Collaborator

gbj commented Jan 3, 2025

I would expect the semver-checks one to be failing because of an unrelated recent change, but possibly also because this is a breaking change.

I would expect the Axum examples that have integrations tests to be failing because Axum 0.8 introduces a breaking change in routing, and we will need to update leptos_axum accordingly.

I haven't looked into the specifics otherwise.

@sabify
Copy link
Contributor Author

sabify commented Jan 4, 2025

The PR should be ready now. The problem was with the new axum's path segment syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants