Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: warn about callbacks outside the ownership tree #3442

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

tversteeg
Copy link
Contributor

Make it clear what is called outside the ownership tree to prevent other people from having the same issue I had with #3437.

@tversteeg tversteeg changed the title docs: add warnings to functions with callbacks outside the ownership tree docs: warn about callbacks outside the ownership tree Jan 4, 2025
@gbj
Copy link
Collaborator

gbj commented Jan 10, 2025

This is a good idea, thanks. I've modified the text to make it a bit more explicit how to do what you're describing, and modified the formatting because the <div class="warning"> approach doesn't work with the usual link generation for docs.

@gbj gbj merged commit 62196ff into leptos-rs:main Jan 10, 2025
69 of 74 checks passed
zakstucke pushed a commit to zakstucke/leptos that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants