Fix: values being moved with the debug_warn! macro when compiling with not(debug_assertions) #3446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the code path by using the
cfg!
macro instead of#[cfg]
attribute. The alternative will move arguments passed to the debug_warn! macro only when compiling without debug_assertions. This version will instead always use additional format arguments by reference.A minimal test code the shows the avoided bug:
The above will complain about
foo
being moved in the unpatched code only when compiling withnot(debug_assertions)
, since in that case the macro expands to a tuple of the arguments which counts as a usage and movesfoo
(into the void, but still).Further advantage of the patched code is that the usual
format_args!
checks run with and withoutdebug_assertions
enable.