Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template dependencies #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Rek-Malorm
Copy link

This PR bumps the dependency versions to align with latest at the time of this PR.
This includes some minor refactor to support changes in these dependencies

@Rek-Malorm Rek-Malorm changed the title Update template dependencies, Update template dependencies Aug 17, 2024
@CodingFlow
Copy link

I think PR is started to get out-of-date; I had to use wasm-bindgen 0.2.95 to avoid build errors. When are we going to merge the PR?

@Rek-Malorm
Copy link
Author

wasm-bindgen is constrained by what was used when installing either trunk or cargo-leptos (Can't rememebre which)

None the less this is derived from what is used in the main examples found here

It may be better to include this example in with the rest but that would be up to the maintainers.
I created this because I spent too much time trying to work it out myself

@recurrence
Copy link

How can we "encourage" the leptos team to merge this?

@CorvusPrudens
Copy link
Collaborator

The issue with this PR is that it too is now out of date by quite a bit.

If this is still useful despite being out of date, please let me know and we can merge it as-is.

@Rek-Malorm
Copy link
Author

I agree with Corvus. I'm not entirely sure this is worth merging in as that does not solve the issue of this repo. The issue is its unmaintained.

Instead of merging this in, could we instead include the content of this repo in the examples of the main repo? The vast majority of changes are identical to what other examples need. So surely it won't hurt to shift where this lives?

@recurrence
Copy link

That's a great idea! The Leptos docs point here but it would be much better if there were a solution in examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants