epoll: opt err log for addConn

lesismal · May 22, 2024 · f136b1c · f136b1c
1 parent 48e6dfa
commit f136b1c
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/poller_epoll.go b/poller_epoll.go
@@ -89,7 +89,6 @@ func (p *poller) addConn(c *Conn) error {
 	if err != nil {
 		p.g.connsUnix[fd] = nil
 		c.closeWithError(err)
-		logging.Error("[%v] add read event failed: %v", c.fd, err)
 	}
 	return err
 }
@@ -112,7 +111,6 @@ func (p *poller) addDialer(c *Conn) error {
 	if err != nil {
 		p.g.connsUnix[fd] = nil
 		c.closeWithError(err)
-		logging.Error("[%v] add read event failed: %v", c.fd, err)
 	}
 	return err
 }
@@ -172,7 +170,16 @@ func (p *poller) acceptorLoop() {
 				conn.Close()
 				continue
 			}
-			p.g.pollers[c.Hash()%len(p.g.pollers)].addConn(c)
+			err = p.g.pollers[c.Hash()%len(p.g.pollers)].addConn(c)
+			if err != nil {
+				logging.Error("NBIO[%v][%v_%v] addConn [fd: %v] failed: %v",
+					p.g.Name,
+					p.pollType,
+					p.index,
+					c.fd,
+					err,
+				)
+			}
 		} else {
 			var ne net.Error
 			if ok := errors.As(err, &ne); ok && ne.Timeout() {