Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use defer c.mux.Unlock in ReadAndGetConn() #429

Closed
wants to merge 1 commit into from
Closed

refactor: use defer c.mux.Unlock in ReadAndGetConn() #429

wants to merge 1 commit into from

Conversation

byene0923
Copy link
Collaborator

ReadAndGetConn() use c.mux lock whole function. maybe can use defer c.mux.Unlock()?

@byene0923 byene0923 requested a review from lesismal May 7, 2024 15:36
@lesismal
Copy link
Owner

lesismal commented May 7, 2024

defer costs a few more nanoseconds, no need to use defer at these simple funcs

@byene0923 byene0923 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesismal lesismal Awaiting requested review from lesismal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byene0923 @lesismal