Expose selected line color #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lesliesam 可以 merge 这个 PR? |
|
有一处代码我提了意见了，修改掉了就可以merge。 |
|
You merge this PR? |
|
@lesliesam can we have this merged, or let us know what we have to change? |
|
@lesliesam 谢谢开源。我现在和PR的作者在同一公司上班，他因为不懂中文沟通上有一些困难，麻烦你把修改需求告诉我，我可以重新提交。感谢。 |
|
Sorry for the very late response. That I remember the line color is not changeable on iOS. Correct me if I am wrong. |
|
@lesliesam 能不能merge这个PR呢。。。谢谢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I exposed selectedLineColor prop (and set the default color to black for ios/android consistency)
Cheers,
Sam