Fix .m4a support in some setups (possibly for other formats not supported by libsndfile) #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also a little string formatting fix |
|
Don't worry about 3.10 and 3.11 tests - they are suffering from some GH action cache issue. If the other tests pass, we can merge it. |
yfyeung
pushed a commit
to yfyeung/lhotse
that referenced
this pull request
Jan 8, 2025
…rted by libsndfile) (lhotse-speech#1427) * LibsndfileBackend: Exclude mp4/m4a/m4b files from set of files it is applicable to * AudioreadBackend: supports_info=True * shar export: fix exception printing * AudioreadBackend: black formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting to merge following changes
Explicitly set m4a as unsupported in
lhotse.audio.backend.LibsndfileBackendbecause it does not support m4a and will not support it in observable future. This is mostly a cosmetic change to eliminate a confusing exception when working with m4a files.Set
AudioreadBackend.supports_infotoTruebecause it has aninfomethod just a line below. This is a bugfix making fallback to this backend actually work.Real world impact: fixing
Recording.from_filefor m4a files in environments wheretorchaudiois not installed.An example of such environment would be the
nvcr.io/nvidia/nemo:24.07container.