Switch to using elfutils GitHub mirror for submodule #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 9ed58f7 ("elfutils: use https protocol for submodule") seems to be causing issues in dependent projects in that it appears as if Cargo, when attempting to clone/update the elfutils git submodule now, fails doing so: > Updating git submodule `https://sourceware.org/git/elfutils.git` > warning: spurious network error (3 tries remaining): early EOF; class=Net (12); code=Eof (-20) > warning: spurious network error (2 tries remaining): early EOF; class=Net (12); code=Eof (-20) > warning: spurious network error (1 tries remaining): early EOF; class=Net (12); code=Eof (-20) > error: failed to load source for dependency `libbpf-sys` > > Caused by: > Unable to update https://github.com/libbpf/libbpf-sys.git?rev=9ed58f7dd737496396b6ea052e771539b3c76e8c > > Caused by: > failed to update submodule `elfutils` > > Caused by: > failed to fetch submodule `elfutils` from https://sourceware.org/git/elfutils.git > > Caused by: > network failure seems to have happened > if a proxy or similar is necessary `net.git-fetch-with-cli` may help here > https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli > > Caused by: > early EOF; class=Net (12); code=Eof (-20) Presumably, that is because of some peculiarities of sourceware.org's Git-over-HTTP support that libgit2 (which I understand is used by Cargo by default) chokes on -- though a more detailed investigation has not been performed. The suggested git-fetch-with-cli workaround does the job, but for reasons probably pertaining how Cargo sources config.toml files, such a setting in libbpf-sys itself won't be honored in the dependent repository. That means that each dependent repository would need to enshrine this setting in its own Cargo configuration. With this change we pull out the big guns and switch to a custom mirror of sourceware's elfutils on GitHub. We already pull all other submodules from GitHub and don't update elfutils all that frequently, so this seems like a reasonable forward. Signed-off-by: Daniel Müller <deso@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9ed58f7 ("elfutils: use https protocol for submodule") seems to be causing issues in dependent projects in that it appears as if Cargo, when attempting to clone/update the elfutils git submodule now, fails doing so:
Presumably, that is because of some peculiarities of sourceware.org's Git-over-HTTP support that libgit2 (which I understand is used by Cargo by default) chokes on -- though a more detailed investigation has not been performed.
The suggested git-fetch-with-cli workaround does the job, but for reasons probably pertaining how Cargo sources config.toml files, such a setting in libbpf-sys itself won't be honored in the dependent repository. That means that each dependent repository would need to enshrine this setting in its own Cargo configuration.
With this change we pull out the big guns and switch to a custom mirror of sourceware's elfutils on GitHub. We already pull all other submodules from GitHub and don't update elfutils all that frequently, so this seems like a reasonable forward.