This repository has been archived by the owner on Nov 21, 2019. It is now read-only.
Apply patch to fix Schematron attribute paths #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| echo "Downloading {$patch} to {$patchTarget}\n"; | ||
| $filesystem->copy($patch, $patchTarget); | ||
| $repo->apply($patchTarget, ['verbose' => true]); |
There was a problem hiding this comment.
I think by default the patches remain tracked in Git as a change not staged for commit. The interaction with updates should work because then a git reset --hard will be performed.
| new Failure( | ||
| 'Attribute must not be empty', | ||
| 6, | ||
| $xpath->query('/example:parent/example:child/@attribute')->item(0) |
There was a problem hiding this comment.
Is this enough context? I guess the DOMNode contained in Failure has some information about what element it was on?
There was a problem hiding this comment.
Yep, since it's retrieved from the document.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies Schematron/schematron#81 (refs libero/jats-support#1 (comment)).
(@FAtherden-eLife took a quick look at the patch and was happy.)