Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check max connections before reverifying addresses #2879

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

achingbrain
Copy link
Member

If the node is close to it's max connections, skip reverification of previously verified addresses.

This is because the verifying node may find it hard to connect and then report that the address is undialable.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner December 6, 2024 12:33
If the node is close to it's max connections, skip reverification
of previously verified addresses.

This is because the verifying node may find it hard to connect and
then report that the address is undialable.
@achingbrain achingbrain force-pushed the fix/check-max-connections-before-reverify branch from 1b5aa4a to 2d2bc1e Compare December 6, 2024 12:36
@achingbrain achingbrain merged commit 9614de7 into main Dec 6, 2024
33 of 34 checks passed
@achingbrain achingbrain deleted the fix/check-max-connections-before-reverify branch December 6, 2024 13:43
@achingbrain achingbrain mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant