-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Everything is lost when the app is killed in background for android #14804
Open
gitgudyyao
wants to merge
10
commits into
libretro:master
Choose a base branch
from
gitgudyyao:androidsavestatefix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−6
Open
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
42184c8
fix Everything is lost when the app is killed in background for android
gitgudyyao da0bd9f
fix 'android' ifdef?
gitgudyyao 8470557
fix Don't use C++ comments in C files
gitgudyyao 7b24159
updated code based on suggestion
gitgudyyao c720e39
updated mistake
gitgudyyao 86cea36
fix silly mistake
gitgudyyao fbdcdac
update mistake
gitgudyyao f5d2649
Update location_driver.h
gitgudyyao 6d5c6e1
Update location_driver.h
gitgudyyao c92e9e1
Update location_driver.h
gitgudyyao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,6 +107,24 @@ bool driver_location_start(void) | |
|
||
void driver_location_stop(void) | ||
{ | ||
#ifdef __ANDROID__ | ||
// Check if the auto save state feature is enabled | ||
settings_t* settings = config_get_ptr(); | ||
bool auto_save_state = settings->bools.auto_save_state; | ||
|
||
if (auto_save_state) | ||
{ | ||
// Make a save state | ||
command_event(CMD_EVENT_SAVE_STATE, NULL); | ||
|
||
// Flush the auto save state to disk | ||
command_event(CMD_EVENT_AUTOSAVE_DELETE, NULL); | ||
} | ||
|
||
// Flush SRAM to disk | ||
gitgudyyao marked this conversation as resolved.
Show resolved
Hide resolved
|
||
command_event(CMD_EVENT_SAVE_FILES, NULL); | ||
#endif | ||
|
||
location_driver_state_t | ||
*location_st = &location_driver_st; | ||
if ( location_st | ||
|
@@ -116,6 +134,8 @@ void driver_location_stop(void) | |
location_st->driver->stop(location_st->data); | ||
} | ||
|
||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. redundant newlines |
||
void driver_location_set_interval(unsigned interval_msecs, | ||
unsigned interval_distance) | ||
{ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong indentation