-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support add/add_item method chaining #141
base: master
Are you sure you want to change the base?
Conversation
Particularly useful when there is one item only or static configuration map (like in http-config.t)
|
I would be very hesitant doing this, depending on any calling code, it used to return something |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may break calling code, that would normally expect something undef
-ish and now get a $self
back
I understand your desire for making it chainable. May I suggest to use |
To be honest, I don't understand this immutability obsession. Like every tool, every approach, it has limitations ... your proposal's limitation is immediately in this pull request, see modified test. Honestly I don't care about this, I'm not using this module, I just recalled it while doing karenetheridge/Test-LWP-UserAgent#4 (that one I use) IMHO itt will just make user's live easier. |
My main concern is not about immutability (although that is very good to have) My great concern is that this change will affect the behaviour of the I, myself, have witnessed breakage because of code in the wild, because of proposed and approved changes in the HTTP realm. |
Particularly useful when there is one item only or
static configuration map (like in http-config.t)