-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test shareRate with fuzzing #918
base: feat/vaults
Are you sure you want to change the base?
Conversation
Hardhat Unit Tests Coverage Summary
Diff against master
Results for commit: 7d05ee2 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start!
Some suggestions and comments left.
Also, looks like it need to me merged with vaults branch once again, because some tests are failing.
import {StdUtils} from "forge-std/StdUtils.sol"; | ||
import {Vm} from "forge-std/Vm.sol"; | ||
import {console2} from "forge-std/console2.sol"; | ||
import {Protocol__Deployment, ILido} from "./Protocol__Deployment.t.sol"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better naming is Protocol__Context so as to put methods related to the protocol interactions later, e.g., adding / removing permissions, impersonating agents, etc...
1d41029
to
7d05ee2
Compare
Test shareRate with fuzzing