CON-1959: add default-value rule #2
Merged
+296
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swain
force-pushed
the
bootstrap
branch
2 times, most recently
from
c2edbc5 to
e2ef35d
Compare
swain
force-pushed
the
CON-1959
branch
4 times, most recently
from
a171f70 to
6829251
Compare
swain
requested review from
aecorredor,
bruce-glazier,
danperkins,
kurtsmurf and
lars-mortenson
aecorredor
approved these changes
Oct 20, 2021
| twoArguments: 'Translate function should have two arguments', | ||
| optionsObject: 'Translate function options should be an object', | ||
| defaultValuePresence: | ||
| 'Translate function defaultValue must a string property on the second argument', |
|
|
||
| if (prop?.value.type === 'Literal' && typeof prop.value.value === 'string') { | ||
| const variableNames = prop.value.value | ||
| .match(/{{[ a-zA-Z0-9]+}}/g) |
There was a problem hiding this comment.
Did we need the white space after the first [?
There was a problem hiding this comment.
yes, to ensure we also match e.g. {{ long }}, not just {{long}}
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR depends on #1.
Motivation
Adding an initial rule for enforcing
defaultValuebehavior.