Merge pull request #176 from liip/override_device_detection

make it possible to override the device detection service

DependencyInjection/Configuration.php

@@ -70,6 +70,7 @@ public function getConfigTreeBuilder()
                     ->end()
                 ->end()
                 ->scalarNode('autodetect_theme')->defaultFalse()->end()
+                ->scalarNode('device_detection')->defaultFalse()->end()
                 ->booleanNode('cache_warming')->defaultTrue()->end()
                 ->booleanNode('load_controllers')->defaultTrue()->end()
                 ->booleanNode('assetic_integration')->defaultFalse()->end()

DependencyInjection/LiipThemeExtension.php

@@ -61,8 +61,14 @@ public function load(array $configs, ContainerBuilder $container)
                 ->addTag('kernel.event_listener', array('event' => 'kernel.response', 'method' => 'onKernelResponse'));
         }
 
+        if (!empty($config['device_detection'])) {
+            $container->setAlias('liip_theme.theme_auto_detect', $config['device_detection']);
+        }
+
         if (!empty($config['autodetect_theme'])) {
+            // @FIXME for 2.0 we should make 'autodetect_theme' a boolean only
             $id = is_string($config['autodetect_theme']) ? $config['autodetect_theme'] : 'liip_theme.theme_auto_detect';
+
             $container->getDefinition($this->getAlias().'.theme_request_listener')
                 ->addArgument(new Reference($id));
         }

README.md

@@ -288,6 +288,22 @@ ensuring that all of the assets are dumped.
 
 Note that this only works with AsseticBundle 2.1 or higher.
 
+### Override the Device Detection
+
+It is possible to override the service used for the device detection. Make sure to either
+extend `DeviceDetection` or implement `DeviceDetectionInterface`:
+
+````yaml
+# app/config/config.yml
+services:
+    my_devcice_detection:
+        class: SomeClass
+
+liip_theme:
+    # ...
+    device_detection: my_devcice_detection
+````
+
 ## Contribution
 
 Active contribution and patches are very welcome. To keep things in shape we