Skip to content

Commit

Permalink
Use monaco editor for Request Body in Query Editor (#4516)
Browse files Browse the repository at this point in the history
Motivation:

Update the debug form to use Microsoft's well-known `Monaco Editor`.

Modifications:

- Integrate Monaco editor to be used in the request body text editor.
  - Easy-to-use editor with bracket highlight, auto-close tags, etc.
  - Enable JSON syntax highlighting
  - Show JSON syntax errors (For future, we will generate JSON schemas for protos to verify the object syntax as well)

Result:

https://user-images.githubusercontent.com/7023385/201191726-1cc4d893-0394-4392-b6be-8e981583b20e.mov

The example used is `GrpcDocServiceTest` the method is `UnaryMethod`. 
This PR is required to enable auto-complete:
- #4518


- Part of #2844 

<!--
Visit this URL to learn more about how to write a pull request description:
https://armeria.dev/community/developer-guide#how-to-write-pull-request-description
-->
  • Loading branch information
Dogacel authored Mar 31, 2023
1 parent dbbe4ca commit 8652e5e
Show file tree
Hide file tree
Showing 22 changed files with 9,549 additions and 11,336 deletions.
6 changes: 4 additions & 2 deletions docs-client/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ if (rootProject.hasProperty('noWeb')) {
}

node {
version = '16.14.0'
npmVersion = '8.5.2'
version = '16.19.1'
download = true
npmInstallCommand = "ci"

Expand All @@ -21,6 +20,9 @@ node {
}
}

// Add the option that works around the dependency conflicts.
tasks.npmInstall.args.add('--legacy-peer-deps')

task buildWeb(type: NpmTask) {
dependsOn tasks.npmInstall

Expand Down
Loading

0 comments on commit 8652e5e

Please sign in to comment.