Update docs and examples for 9.0.0 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ocadaruma
commented
Aug 14, 2024
ocadaruma
commented
- TaskMetadata as header #238 brings a breaking change, which requires to update docs
kawamuray
suggested changes
Aug 14, 2024
docs/consuming-any-topic.adoc
Outdated
| But Decaton has the capability to consume arbitrary topics other than topics consisting records of Decaton protocol. | ||
| [NOTE] | ||
| ==== | ||
| * From Decaton 9.0.0, DecatonClient no longer wraps tasks with DecatonTaskRequest protobuf message. |
There was a problem hiding this comment.
Hm, maybe we can emphasize that most users has no motivation to refer this doc anymore unless they want to do something very niche in the first line of this document, with bold letters.
I know it's written below but my point is not as one of these listings but as the headline of the document.
There was a problem hiding this comment.
Sorry, I recalled that we still need to use TaskExtractor for arbitrary topic which is not produced by DecatonClient, because ProcessorsBuilder.consuming(String topic, Deserializer<T> deserializer) assumes task is serialized as DecatonTaskRequest when dt_meta header is absent.
kawamuray
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.