-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vue extractor error reporting #1924
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1924 +/- ##
==========================================
- Coverage 76.65% 76.11% -0.54%
==========================================
Files 81 85 +4
Lines 2090 2114 +24
Branches 533 539 +6
==========================================
+ Hits 1602 1609 +7
- Misses 375 393 +18
+ Partials 113 112 -1 ☔ View full report in Codecov by Sentry. |
sourceMap: true, | ||
filename, | ||
ignoreEmpty: true, | ||
}) | ||
|
||
if (parsedErrors.length) { | ||
console.error("Error while parsing:") | ||
throw parsedErrors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if throwing errors is the right approach. Should I simply log these errors and proceed with extraction?
@JSteunou could you please take a look? |
This would make stop at the 1st error. Is this the behavior we want? Just logging and throw? |
@andrii-bodnar I think we can close this PR in favor of #1925, since we are planning to deprecate |
Description
Report errors from
parse
andcompileTemplate
in Vue Extractor.Types of changes
Fixes #1627
Checklist