Skip to content

Commit

Permalink
Merge pull request #43 from phillc/master
Browse files Browse the repository at this point in the history
Automatically commit manifest generation
  • Loading branch information
phillc authored Mar 30, 2020
2 parents b5c4a89 + 6b524ab commit 9ff6f78
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 13 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/docker-hub.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@ jobs:
steps:
- uses: actions/checkout@master
- name: Build
run: make build-linux
run: make linode
- name: Publish latest to Registry
uses: elgohr/Publish-Docker-Github-Action@master
with:
name: linode/linode-blockstorage-csi-driver
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
tags: "latest,${{ github.event.release.tag_name }}"
workdir: "app/linode"
21 changes: 21 additions & 0 deletions .github/workflows/generate-manifest.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Release manifests
on:
release:
types: [published]
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- name: Build manifest
run: "./hack/release-yaml.sh ${{ github.event.release.tag_name }}"
- name: Commit files
run: |
git config --local user.email "action@github.com"
git config --local user.name "GitHub Action"
git add -- pkg/linode-bs/deploy/releases/linode-blockstorage-csi-driver*\.yaml
git commit -m "Update manifests"
- name: Push changes
uses: ad-m/github-push-action@master
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ linode-container: linode

.PHONY: push
push: linode-container
#@echo "$$DOCKER_PASSWORD" | docker login -u "$$DOCKER_USERNAME" --password-stdin
docker push $(IMAGE_TAG)

.PHONY: verify
Expand Down
11 changes: 0 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,17 +138,6 @@ persistence

Want to improve the linode-blockstorage-csi-driver? Please start [here](.github/CONTRIBUTING.md).

## Doing a Release

1. Open up the Makefile.
1. Check that the `IMAGE_VERSION` variable is set to the value that you want. You should always start with a `canary` release.
1. run `make push`. As of this writing, the `push` target depends upon the `linode-container`, `linode`, `vendor, and `test` targets. So the code should be vendored, the tests should run, the build should run, a container should be built, and it should be pushed to the container registry.
1. Test the new canary version on a live cluster.
1. Change `IMAGE_VERSION` to the new version of the CSI driver, for exmaple `v0.2.1`
1. Run `make push` again
1. Push a git tag for the new version, perferrably pgp signed.
1. Make a GitHub release and write the release notes for the release.

## Join us on Slack

For general help or discussion, join the [Kubernetes Slack](http://slack.k8s.io/) channel [#linode](https://kubernetes.slack.com/messages/CD4B15LUR).
Expand Down

0 comments on commit 9ff6f78

Please sign in to comment.