Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] : fix random failures in e2e tests due to curl error #287

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

rahulait
Copy link
Collaborator

@rahulait rahulait commented Jan 3, 2025

General:

Sometimes, e2e test would fail even if its within a forloop block to retry few times. If curl command returned non-zero code, it would result in script to fail. With these fixes, we are now letting code to retry few times based on the for loop.

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions bot added the testing for updates to the testing suite in the changelog. label Jan 3, 2025
@rahulait rahulait changed the title [test] : fix random failures due to curl error [test] : fix random failures in e2e tests due to curl error Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.22%. Comparing base (57c5261) to head (67738e3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   63.22%   63.22%           
=======================================
  Files          12       12           
  Lines        2415     2415           
=======================================
  Hits         1527     1527           
  Misses        736      736           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulait rahulait force-pushed the fix-random-failures branch from 563a339 to 67738e3 Compare January 6, 2025 16:03
Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rahulait rahulait merged commit 8c67954 into main Jan 6, 2025
7 checks passed
@rahulait rahulait deleted the fix-random-failures branch January 9, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants