Skip to content

Commit

Permalink
feedback @jaalah-akamai
Browse files Browse the repository at this point in the history
  • Loading branch information
abailly-akamai committed Nov 6, 2024
1 parent 75473e4 commit 2257a94
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 0 additions & 1 deletion packages/manager/src/features/Volumes/VolumesLanding.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ export const VolumesLanding = () => {
const search: VolumesSearchParams = useSearch({ strict: false });
const pagination = usePaginationV2({
currentRoute: '/volumes',
initialPage: 1,
preferenceKey: VOLUME_TABLE_PREFERENCE_KEY,
searchParams: (prev) => ({
...prev,
Expand Down
5 changes: 3 additions & 2 deletions packages/manager/src/hooks/usePaginationV2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ export interface UsePaginationV2Props<T extends TableSearchParams> {
currentRoute: ToSubOptions['to'];
/**
* The initial page pagination is set to - defaults to 1, it's unusual to set this.
* @default 1
*/
initialPage: number;
initialPage?: number;
/**
* A key used to store a user's preferred page size for a specific table.
*/
Expand All @@ -49,7 +50,7 @@ export interface UsePaginationV2Props<T extends TableSearchParams> {

export const usePaginationV2 = <T extends TableSearchParams>({
currentRoute,
initialPage,
initialPage = 1,
preferenceKey,
queryParamsPrefix,
searchParams,
Expand Down

0 comments on commit 2257a94

Please sign in to comment.