fix the smoke tests

linode · Dec 10, 2024 · 2d228e2 · 2d228e2
1 parent cc2198e
commit 2d228e2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/manager/cypress/e2e/core/volumes/create-volume.smoke.spec.ts b/packages/manager/cypress/e2e/core/volumes/create-volume.smoke.spec.ts
@@ -11,6 +11,7 @@ import {
 } from 'support/intercepts/linodes';
 import {
   mockCreateVolume,
+  mockGetVolume,
   mockGetVolumes,
   mockDetachVolume,
   mockGetVolumeTypesError,
@@ -85,6 +86,7 @@ describe('volumes', () => {
 
     mockGetVolumes([]).as('getVolumes');
     mockCreateVolume(mockVolume).as('createVolume');
+    mockGetVolume(mockVolume).as('getVolume');
     mockGetVolumeTypes(mockVolumeTypes).as('getVolumeTypes');
 
     cy.visitWithLogin('/volumes', {
@@ -114,7 +116,7 @@ describe('volumes', () => {
 
     mockGetVolumes([mockVolume]).as('getVolumes');
     ui.button.findByTitle('Create Volume').should('be.visible').click();
-    cy.wait(['@createVolume', '@getVolumes']);
+    cy.wait(['@createVolume', '@getVolume', '@getVolumes']);
     validateBasicVolume(mockVolume.label);
 
     ui.actionMenu
@@ -193,6 +195,7 @@ describe('volumes', () => {
 
     mockDetachVolume(mockAttachedVolume.id).as('detachVolume');
     mockGetVolumes([mockAttachedVolume]).as('getAttachedVolumes');
+    mockGetVolume(mockAttachedVolume).as('getVolume');
     cy.visitWithLogin('/volumes', {
       preferenceOverrides,
       localStorageOverrides,
@@ -209,6 +212,8 @@ describe('volumes', () => {
 
     ui.actionMenuItem.findByTitle('Detach').click();
 
+    cy.wait('@getVolume');
+
     ui.dialog
       .findByTitle(`Detach Volume ${mockAttachedVolume.label}?`)
       .should('be.visible')

diff --git a/packages/manager/cypress/e2e/core/volumes/upgrade-volume.spec.ts b/packages/manager/cypress/e2e/core/volumes/upgrade-volume.spec.ts
@@ -10,7 +10,11 @@ import {
   mockGetLinodeDisks,
   mockGetLinodeVolumes,
 } from 'support/intercepts/linodes';
-import { mockMigrateVolumes, mockGetVolumes } from 'support/intercepts/volumes';
+import {
+  mockMigrateVolumes,
+  mockGetVolumes,
+  mockGetVolume,
+} from 'support/intercepts/volumes';
 import { ui } from 'support/ui';
 
 describe('volume upgrade/migration', () => {
@@ -23,6 +27,7 @@ describe('volume upgrade/migration', () => {
     });
 
     mockGetVolumes([volume]).as('getVolumes');
+    mockGetVolume(volume).as('getVolume');
     mockMigrateVolumes().as('migrateVolumes');
     mockGetNotifications([migrationScheduledNotification]).as(
       'getNotifications'
@@ -53,7 +58,7 @@ describe('volume upgrade/migration', () => {
         .click();
     });
 
-    cy.wait(['@migrateVolumes', '@getNotifications']);
+    cy.wait(['@migrateVolumes', '@getVolume', '@getNotifications']);
 
     cy.findByText('UPGRADE PENDING').should('be.visible');