Merge branch 'aclp_develop' into feature/create-alert-form-dimension-…

…filters-and-trigger-conditions

CODEOWNERS

@@ -1,5 +1 @@
-# Default code owners
-* @linode/frontend
-
-# Frontend SDET code owners for Cypress tests
-/packages/manager/cypress/ @linode/frontend-sdet
+* @ACLPManager/reviewers

docs/PULL_REQUEST_TEMPLATE.md

@@ -53,18 +53,21 @@ Please specify a release date (and environment, if applicable) to guarantee time
 
 ## As an Author, to speed up the review process, I considered 🤔
 
-👀 Doing a self review
-❔ Our [contribution guidelines](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md)
-🤏 Splitting feature into small PRs
-➕ Adding a [changeset](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md#writing-a-changeset)
-🧪 Providing/improving test coverage
- 🔐 Removing all sensitive information from the code and PR description
-🚩 Using a feature flag to protect the release
-👣 Providing comprehensive reproduction steps
-📑 Providing or updating our documentation
-🕛 Scheduling a pair reviewing session
-📱 Providing mobile support
-♿  Providing accessibility support
+*Check all that apply*
+
+- [ ] Use React components instead of HTML Tags
+- [ ] Proper naming conventions like cameCase for variables & Function & snake_case for constants
+- [ ] Use appropriate types & avoid using "any"
+- [ ] No type casting & non-null assertions
+- [ ] Adding a [changeset](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md#writing-a-changeset)
+- [ ] Providing/Improving test coverage
+- [ ] Use sx props to pass styles instead of style prop
+- [ ] Add JSDoc comments for interface properties & functions
+- [ ] Use strict equality (===) instead of double equal (==)
+- [ ] Use of named arguments (interfaces) if function argument list exceeds size 2
+- [ ] Destructure the props
+- [ ] Keep component size small & move big computing functions to separate utility
+- [ ] 📱 Providing mobile support
 
 <br/>
 

package.json

@@ -63,5 +63,6 @@
   "volta": {
     "node": "20.17.0"
   },
-  "dependencies": {}
+  "dependencies": {},
+  "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
 }

packages/api-v4/.changeset/pr-11397-upcoming-features-1734001143561.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Upcoming Features
+---
+
+fix types for iam api ([#11397](https://github.com/linode/manager/pull/11397))

packages/api-v4/.changeset/pr-11426-changed-1734381690407.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Changed
+---
+
+BaseDatabase total_disk_size_gb and used_disk_size_gb are always expected and used_disk_size_gb can be null  ([#11426](https://github.com/linode/manager/pull/11426))

packages/api-v4/.changeset/pr-11433-changed-1734483970019.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Changed
+---
+
+Renamed `AvailableMetrics` type to `MetricDefinition` ([#11433](https://github.com/linode/manager/pull/11433))

packages/api-v4/.changeset/pr-11433-removed-1734484000708.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Removed
+---
+
+`MetricDefinitions` type ([#11433](https://github.com/linode/manager/pull/11433))

packages/api-v4/src/cloudpulse/services.ts

@@ -3,13 +3,13 @@ import Request, { setData, setMethod, setURL } from '../request';
 import {
   JWEToken,
   JWETokenPayLoad,
-  MetricDefinitions,
+  MetricDefinition,
   ServiceTypesList,
 } from './types';
-import { ResourcePage as Page } from 'src/types';
+import { ResourcePage } from 'src/types';
 
 export const getMetricDefinitionsByServiceType = (serviceType: string) => {
-  return Request<Page<MetricDefinitions>>(
+  return Request<ResourcePage<MetricDefinition>>(
     setURL(
       `${API_ROOT}/monitor/services/${encodeURIComponent(
         serviceType

packages/api-v4/src/cloudpulse/types.ts

@@ -89,11 +89,7 @@ export interface AclpWidget {
   size: number;
 }
 
-export interface MetricDefinitions {
-  data: AvailableMetrics[];
-}
-
-export interface AvailableMetrics {
+export interface MetricDefinition {
   label: string;
   metric: string;
   metric_type: string;
@@ -222,3 +218,8 @@ export interface Alert {
   created: string;
   updated: string;
 }
+
+export interface DataSet {
+  [label: string]: number;
+  timestamp: number;
+}

packages/api-v4/src/databases/types.ts

@@ -165,16 +165,8 @@ interface BaseDatabase extends DatabaseInstance {
   port: number;
   /** @Deprecated used by rdbms-legacy only, rdbms-default always uses TLS */
   ssl_connection: boolean;
-  /**
-   * total_disk_size_gb is feature flagged by the API.
-   * It may not be defined.
-   */
-  total_disk_size_gb?: number;
-  /**
-   * used_disk_size_gb is feature flagged by the API.
-   * It may not be defined.
-   */
-  used_disk_size_gb?: number;
+  total_disk_size_gb: number;
+  used_disk_size_gb: number | null;
 }
 
 /** @deprecated TODO (UIE-8214) remove POST GA */

packages/api-v4/src/iam/types.ts

@@ -1,9 +1,4 @@
-export interface IamUserPermissions {
-  account_access: AccountAccessType[];
-  resource_access: ResourceAccess[];
-}
-
-type ResourceType =
+export type ResourceTypePermissions =
   | 'linode'
   | 'firewall'
   | 'nodebalancer'
@@ -16,38 +11,49 @@ type ResourceType =
   | 'account'
   | 'vpc';
 
-type AccountAccessType =
+export type AccountAccessType =
   | 'account_linode_admin'
   | 'linode_creator'
+  | 'linode_contributor'
   | 'firewall_creator';
 
-type RoleType = 'linode_contributor' | 'firewall_admin';
+export type RoleType =
+  | 'linode_contributor'
+  | 'firewall_admin'
+  | 'linode_creator'
+  | 'firewall_creator';
 
+export interface IamUserPermissions {
+  account_access: AccountAccessType[];
+  resource_access: ResourceAccess[];
+}
 export interface ResourceAccess {
   resource_id: number;
-  resource_type: ResourceType;
+  resource_type: ResourceTypePermissions;
   roles: RoleType[];
 }
 
-export interface IamAccountPermissions {
-  account_access: Access[];
-  resource_access: Access[];
-}
-
 type PermissionType =
   | 'create_linode'
   | 'update_linode'
   | 'update_firewall'
   | 'delete_linode'
   | 'view_linode';
 
-interface Access {
-  resource_type: ResourceType;
+export interface IamAccountPermissions {
+  account_access: IamAccess[];
+  resource_access: IamAccess[];
+}
+
+export interface IamAccess {
+  resource_type: ResourceTypePermissions;
   roles: Roles[];
 }
 
 export interface Roles {
   name: string;
   description: string;
-  permissions?: PermissionType[];
+  permissions: PermissionType[];
 }
+
+export type IamAccessType = keyof IamAccountPermissions;

packages/manager/.changeset/pr-11118-upcoming-features-1729147903845.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Add labels / titles for all global filters in aclp ([#11118](https://github.com/linode/manager/pull/11118))

packages/manager/.changeset/pr-11339-fixed-1732776925827.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+Events landing page lists events in wrong order ([#11339](https://github.com/linode/manager/pull/11339))

packages/manager/.changeset/pr-11390-tests-1733844253656.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Cypress test flake: Rebuild Linode ([#11390](https://github.com/linode/manager/pull/11390))

packages/manager/.changeset/pr-11397-upcoming-features-1733916688951.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Add new user details components for iam ([#11397](https://github.com/linode/manager/pull/11397))

packages/manager/.changeset/pr-11411-tests-1734023093705.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Update mock region for LKE cluster creation test ([#11411](https://github.com/linode/manager/pull/11411))

packages/manager/.changeset/pr-11418-tech-stories-1734276290091.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tech Stories
+---
+
+Refactor Domains Routing (Tanstack Router) ([#11418](https://github.com/linode/manager/pull/11418))

packages/manager/.changeset/pr-11422-tests-1734356272451.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Cypress tests to validate errors in Linode Create Backups tab ([#11422](https://github.com/linode/manager/pull/11422))

packages/manager/.changeset/pr-11426-fixed-1734381380797.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+DBaaS Resize tab Used field is displaying just GB on provisioning database cluster ([#11426](https://github.com/linode/manager/pull/11426))

packages/manager/.changeset/pr-11430-tech-stories-1734463578200.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tech Stories
+---
+
+Replace react-select instances in /Users with new Select ([#11430](https://github.com/linode/manager/pull/11430))

packages/manager/.changeset/pr-11431-fixed-1734558226981.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+Various bugs in Managed tables ([#11431](https://github.com/linode/manager/pull/11431))

packages/manager/.changeset/pr-11433-tech-stories-1734484023886.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tech Stories
+---
+
+Fixed CloudPulse metric definition types ([#11433](https://github.com/linode/manager/pull/11433))

packages/manager/.changeset/pr-11435-tests-1734516339389.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Cypress test to validate aria label of Linode IP Addresses action menu ([#11435](https://github.com/linode/manager/pull/11435))

packages/manager/.changeset/pr-11437-fixed-1734527875368.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+ARIA label of action menu in Domains Landing table row ([#11437](https://github.com/linode/manager/pull/11437))

packages/manager/.changeset/pr-11443-removed-1734624899643.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Removed
+---
+
+`Images are not encrypted warning` warning ([#11443](https://github.com/linode/manager/pull/11443))

packages/manager/.changeset/pr-11448-tests-1734703218321.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Add unit tests to validate aria-labels of Action Menu for Linode IPs & ranges ([#11448](https://github.com/linode/manager/pull/11448))

packages/manager/.changeset/pr-11460-fixed-1735030571347.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+Discrepancy in Object Storage Bucket size in CM ([#11460](https://github.com/linode/manager/pull/11460))

packages/manager/.eslintrc.cjs

@@ -90,6 +90,7 @@ module.exports = {
       files: [
         // for each new features added to the migration router, add its directory here
         'src/features/Betas/**/*',
+        'src/features/Domains/**/*',
         'src/features/Volumes/**/*',
       ],
       rules: {

packages/manager/CHANGELOG.md

@@ -4,6 +4,21 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2024-12-20] - v1.133.2
+
+### Fixed:
+
+- Incorrectly displayed region options ([#11449](https://github.com/linode/manager/pull/11449))
+
+
+## [2024-12-19] - v1.133.1
+
+### Fixed:
+
+- Filter available regions in Object Gen2 Create Drawer and Access Keys List based on endpoint capabilities ([#11432](https://github.com/linode/manager/pull/11432))
+- Region name display in Gen2 warning notices when regions are unavailable due to format mismatch ([#11432](https://github.com/linode/manager/pull/11432))
+
+
 ## [2024-12-10] - v1.133.0
 
 ### Added: