Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.111.0 - release β†’ staging #10136

Merged
merged 49 commits into from
Feb 5, 2024
Merged

Release v1.111.0 - release β†’ staging #10136

merged 49 commits into from
Feb 5, 2024

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Feb 1, 2024

Description πŸ“

Cloud Manager Changelog [2024-02-05]

Cloud Manager - v1.111.0

Changed:

  • Table CollapsibleRow icon orientation (#10119)

Fixed:

  • Incorrect color of VPC Action Buttons in Dark Mode (#10101)
  • Breadcrumb label in NodeBalancers details & create pages (#10127)

Tech Stories:

  • Improve NodeBalancer Restricted User Experience (#10095)
  • Update Storybook & add @babel/traverse resolution (#10097)
  • Remove unused @types/reach__router package (#10099)
  • Add RegionMultiSelect Component (#10084)
  • Remove unused react-page-visibility and @types/react-page-visibility packages (#10099)
  • Move simple-git from dependencies to devDependencies (#10099)
  • Remove kubernetesDashboardAvailability feature flag (#10121)
  • Refactor AccessKeyTable - Eliminate React anti-patterns (#10124)
  • React Query for Events (#9949)
  • Upgrade to Vitest 1.2.0 (#10070)
  • Enable TypeScript type checks in the Cypress directory (#10086)

Tests:

  • Add Cypress tests for restricted user billing flows (#10070)
  • Fix test failure related to Ubuntu 23.04 Image deprecation (#10091)
  • Add regression tests for deleting users on the Users & Grants page. (#10093)
  • Fix Domains landing page empty state test flake (#10094)
  • Add Cypress test for VPC assignment during Linode create flow (#9939)

Upcoming Features:

  • Create Load Balancer Summary page (#10018)
  • OBJ MultiCluster - Add regions field in Create Access Key Drawer (#10034)
  • Add Rule support to ACLB Full Create Flow (#10035)
  • Update ACLB Configuration Port Copy (#10079)
  • Add search filter in Clone Linode and Create Linode from Backup flows (#10088)
  • Handle ACLB Account Capability (#10098)
  • Add new ACLB logo (#10105)
  • Put newly created ACLB Rules at the top of the table upon creation (#10107)
  • Change ACLB Rule Execution Order Column (#10112)
  • Add ACLB rule Path Regex match type (#10126)
  • Update ACLB Copy (#10128)
  • Implement Account Switching Functionality (#10064)
  • Add user_type to /profile endpoint for Parent/Child user roles (#10080)
  • Add business partner table to Users & Grants child view (#10076)
  • Disable adding and editing API tokens for proxy users (#10109)
  • Restrict proxy users from updating username/email (#10103)
  • Add Verification Banner for Child Accounts (#10085)
  • Add Placement Groups Detail Page (#10096)
  • Add Placement Groups Create/Rename Drawers (#10106)
  • Add Placement Groups Landing Page (#10068)
  • Add Placement Groups Landing Page empty state (#10075)

Validation - v0.39.0

Upcoming Features:

  • Add path_regex as a valid ACLB rule match field (#10126)

API-v4 - v0.109.0

Fixed:

  • Accept InterfacePayload type when creating a Linode with interfaces specified (#10086)
  • Remove incorrect _initial property on Event type (#9949)

Upcoming Features:

  • Add user_type to /profile endpoint for Parent/Child user roles (#10080)
  • Add Akamai Cloud Load Balancer to AccountCapability type (#10098)

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

abailly-akamai and others added 30 commits January 19, 2024 09:09
* Initial commit - menu entry, routes and skeletons

* Saving progress: table rows

* Saving progress: Table data

* Tests and cleanup

* moar cleanup

* Compliance col remove, styling and cleanup

* Cleanup and changeset

* Fix unit test

* Update icon and limits

* Feedback

* Moar Feedback
…enhancements (#10070)

* Upgrade Vitest from 1.0.x to 1.2.x

* Enable contact info unit test that was fixed by Vitest upgrade

* Disable payment method action menu items for restricted and child users

* Add QA data attribute to Tooltip component

* Add intercept util for profile grants request

* Add tooltip UI helper

* Add Cypress tests for Parent/Child restricted and child user billing UX

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
* update copy

* update error logic

* remove unrelated change

* Added changeset: Update AGLB Configuration Port Copy

* add logic to change port based on protocol

* add logic to change port based on protocol

* Update packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Configurations/constants.tsx

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…tion (#10091)

* Replace Ubuntu 23.04 with 23.10 when checking Image dropdown
* upcoming: [M3-7608]: Placement Groups Landing page empty state

* upcoming: [M3-7608]: Add changeset and remove unnecessary file

* fix docs link unit test
* Fix flake by asserting element does not exist
Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
* RegionMultiSelect

* RegionMultiSelect Story

* Added changeset: RegionMultiSelect Component

* unit test - RegionMultiSelect

* PR - feedback @jaalah-akamai @abailly-akamai

* Add border to Select / Deselect All option

* Extract RenderOption as a Separate Component in RegionMultiSelect

* Use RegionOption in RegionSelect

* RegionMultiSelect -Test coverage

* Update packages/manager/src/components/RegionSelect/RegionMultiSelect.stories.tsx

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>

---------

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.7 to 5.0.12.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.0.12/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.0.12/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…10097)

* Update storybook & add @babel/traverse resolution

* Added changeset: Update storybook & add @babel/traverse resolution
* Add Clone Linode power-off notice

* Add new feature flag for Linode Clone UI updates

* Added changeset: Clone Linode power-off notice

* Reduce spacing between notices

* Refactored DebouncedSearchTextField to enable external state management

* Add search to SelectLinodePanel and autopopulate when cloning

* Fix bug causing filter value to update every time a Linode is selected

* Make clear icon blue on hover

* Gate changes behind feature flag

* Added changeset: Search filter in Clone Linode and Create Linode from Backup flows

* Added -> upcoming

* Add explanatory comment

* Change InputAdornment to IconButton

* Add missing useEffect dependencies

* Fix unused customValue prop

* Simplify export
…Access Key Flow (#10034)

* Regions Multi Select

* Add Regions field to AccessKeyDrawer

* Added changeset: OBJ MultiCluster - Add regions field in Create Access Key Drawer

* Get all buckets from regions useObjectStorageBucketsFromRegions

* Show validation error when no regions are selected

* Mock service for OBJ create key

* Code cleanup

* Create BucketPermissionsTable

* Implement Copy All

* Mock disable OBJ multicluster feature flag for access key tests

* Create HostNamesDrawer

* code cleanup

* User session feedback

* Update AccessKeyRegions.tsx

* fix broken tests.

* PR - Feedback from @jdamore-linode

* PR - feedback use RemovableSelectionsList to render selected regions

* Code cleanup

* Code cleanup

* Code cleanup

* Remove omc_createObjectStorageKeysSchema as it is not required.

* Fix - remove option

* Code cleanup

* PR feedback - @dwiley-akamai

---------

Co-authored-by: Joe D'Amore <jdamore@linode.com>
)

* fix VPC action button colors

* Added changeset: VPC Action Buttons Incorrect Color in Dark Mode

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* add new logo to primary navigation

* remove todo comment

* use new logo in the add new menu

* Added changeset: Add new ACLB logo

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…10093)

* M3-7483 Add test to delete users on "Users & Grants" page

* fix comments

* Added changeset: Add regression tests for deleting users on Users & Grants page.
* clean up

* add changesets

* update yarn.lock

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…xy users (#10109)

* Disable creating and editing API tokens for proxy users

* Added changeset: Disable adding and editing API tokens for proxy users

* A feature flag would be nice

* Add Cypress test coverage

* Fix test comments

* Add mocked feature flag to test

* Address feedback: use tooltip ui helper in test
* Initial components

* Wrap up with tests

* Fix test!

* Changeset and cleanup

* Feedback

* Add test and story

* cleanup

* feedback

* oops fix test

* Moar Feedback
…#10086)

* Use ESM-friendly method to get directory name in Vite configs

* Extend Cypress tsconfig from Cloud Manager tsconfig

* Fix Cypress test directory tsc issues

* Add types for chai-string

* Typecheck Cypress during Git precommit hook

---------

Co-authored-by: Alban Bailly <abailly@akamai.com>
* events landing

* add linode events support with filter

* clean up

* add poller

* add event handlers and cache updater

* hook up toasts

* fix bug by removing early return and start refactoring

* refactor event consumers

* finish general refactor

* optimize

* fixes and clean up

* fix cache updater bug

* make the query updater update all queries

* poc: use cursor based pagination

* remove old code

* use `id` for cusour based pagination and clean up

* move things around to minimize re-renders

* handle accounts with no events and fix queryKey bug

* fix incorrect query key causing `useInProgressEvents` not to work

* add comments

* comment and test filtering

* explain pagination approach

* clean up and test `EventsLanding`

* remove `src/__data__/events.ts`

* remove more unused helper functions

* reorganize helper functions

* move `generatePollingFilter` to `event.helpers.ts`

* extract helper into `getExistingEventDataForPollingFilterGenerator` and unit test

* handle and test in-progress event edge case

* remove outdated comment

* don't pass an empty object if we don't have a `pageParam`

* improve interval defaults

* disable query that is for reading data only

* make polling backoff match existing backoff

* clean up interval hooks

* simplify polling interval

* fixing duplicate pull due to rules of hooks

* clean up new polling interval

* add changesets

* clean up mount timestamp

* clean up query key for poller

* rename `resetEventsPolling` to `checkForNewEvents`

* Apply suggestions from @jdamore-linode

Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com>

* Update packages/manager/src/queries/events/events.ts

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com>
…il (#10103)


Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
* Create EditLoadBalancerLabel

* Added changeset: Create Load Balancer Summary page.

* Create EditLoadBalancerRegions

* rename EditLoadBalancerLabel

* Create LoadBalancerSummary

* Create LoadBalancerCreateFormWrapper

* Code cleanup

* Billing Summary sections

* EditConfigurationDetails

* EditRoutes

* EditLoadBalancerConfigurations

* Update LoadBalancerSummary.styles.ts

* Disabel Review button incase of validation errors

* Code cleanup

* test coverage - EditRouteDrawer

* Update EditRouteDrawer.test.tsx

* test coverage - ConfigurationAccordionHeader

* test coverage - RouteAccordionHeader

* test coverage - ConfigurationAccordion

* Update with comments

* Update packages/manager/.changeset/pr-10018-upcoming-features-1703185915854.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Add Todo item to update links

* Update LoadBalancerSummary.tsx

* PR feedback.

* Update packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerSummary/LoadBalancerSummary.tsx

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Revert "PR feedback."

This reverts commit 5cb1279.

* PR - Feedback - Remove background color, and align regions title

* Reduce spacing around summary section

* PR -feedback - control opening accordion upon clicking edit button

* PR - feedback @bnussman-akamai @hana-linode

* Copy updates

---------

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
* Add table and separate out partner users from all users

* Display Manage Access button for proxy users; label tables

* Rename variable and clean up

* Added changeset: Users & Grants: add business partner table to child view

* Display correct table cols; update variable names

* Adjust styling; properly feature flag table headings

* Disable Close Account button for child users

* Disable Close Account button for proxy users; add tests

* Add unit test for proxy user UserRow

* Switch notice to button tooltip

* Fix misleadingly passing Button.test.tsx

* Update test coverage for Close Account button tooltip

* Fix failing e2e test and add coverage for proxy user flow

* Use user_type from  and update tests

* Address feedback: center button with header; update mocks

* Address feedback: make table components

* Remove bad any type

* Address feedback: Add error, loading states to Close Account button

* Rely on parent user type, no need for childAccounts

* Address feedback: allow unrestricted proxy user to see themselves

* Fix typo

* Address feedback: filter users more efficiently with array reduce

* Make linter happy with sort imports

* Revert change to MSW for testing user_type
#9939)

* Add tests assigning VPCs during Linode creation flow
…table upon creation (#10107)

* put new rule at beginning of rules array

* Added changeset: Put newly created ACLB Rules at the top of the table upon creation

* fix comment

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…and Values (#10112)

* change `Execution` ➑️ `Execution Order` and use numeric value

* update unit test

* Added changeset: Change ACLB Rule Execution Order Column

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
cpathipa and others added 6 commits January 31, 2024 11:08
…patterns (#10124)

* Refactor renderRows to AccessKeyTableRows  component

* Refactor renderContent  to AccessKeyTableBody component

* Organize AccessKeyTable component

* Added changeset: Refactor AccessKeyTable - Eliminate react anti patterns.

* Fix console warning

* PR - Feedback - @carrillo-erik
* add new match type

* add changesets

* add copy for Match Type Tooltip

* fix failing test

* update example and add copy

* new copy and placeholder from UX

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* start adding new copy

* update certs copy

* update certs copy

* revert unintended change

* continue adding new copy changes

* move some copy to constants

* Added changeset: Update ACLB Copy

* fix unintended change

* fix other SNI form

* more copy updates and test fixes

* fix unit test

* fix routes e2e test

* remove comma

* use correct docs link urls

* Update packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Certificates/constants.tsx

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@cpathipa cpathipa requested review from a team as code owners February 1, 2024 16:26
@cpathipa cpathipa requested review from jdamore-linode, jaalah-akamai and abailly-akamai and removed request for a team February 1, 2024 16:26
@cpathipa cpathipa added the Release β†’ Staging Pre-Release: Release β†’ Staging label Feb 1, 2024
@cpathipa cpathipa self-assigned this Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

Coverage Report: βœ…
Base Coverage: 79.94%
Current Coverage: 81.15%

## Description πŸ“
Hide error message for $0 regions since that is not technically an error. Continue to display the error icon otherwise.

## Changes  πŸ”„
List any change relevant to the reviewer.
- Error message tooltip no longer displayed for $0 region prices in Linode and Kubernetes Create
- Plus and minus and Add buttons are no longer disabled in Kubernetes Create Plan table if the price is $0

## How to test πŸ§ͺ

### Reproduction steps
- On another branch/prod, go to Linode/Kubernetes Create
- Select the Madrid region
- Notice the error icon for both the `$0` hourly price and `$--.--` monthly price
- Notice the disabled plus, minus, add buttons in the Kubernetes Create Plan table

### Verification steps 
- Go to Linode/Kubernetes Create and select the Madrid region
- You should no longer see an error icon for the `$0` hourly price. You should continue to see an error icon for the `$--.--` monthly price
- The plus, minus, add buttons should no longer be disabled in the Kubernetes Create Plan table

```
yarn test KubernetesPlanSelection
yarn test PlanSelection
```
bnussman-akamai
bnussman-akamai previously approved these changes Feb 5, 2024
abailly-akamai
abailly-akamai previously approved these changes Feb 5, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ Approving pending test results

@cpathipa cpathipa merged commit ec5aa17 into staging Feb 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release β†’ Staging Pre-Release: Release β†’ Staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.