-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poc: Run all GitHub Actions on M1 macOS runners #10155
poc: Run all GitHub Actions on M1 macOS runners #10155
Conversation
👀 very interested to see how this pans out, I wasn't aware you could even get Apple Silicon runners. I'm curious how any non- |
Looks like some steps like
|
This is great - will speed up test and coverage jobs lots |
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am happy to give this a try! Only concern is something not going well during a release.
I think I remember @jdamore-linode mention we could have duplicate workflows (one runs on unbuntu
the other on macos
). Since we can enable them or disable them through the UI seems like a good compromise, however instead of managing two identical actions we could store the runs-on
in an env variable?
I think we decided that it would be easiest to just switch over and not maintain a matrix of operating systems. What do you think @jdamore-linode? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be fine to make the switch and keep an eye on things
@bnussman-akamai I agree! I think as long as we merge this with a day or two to spare til the next release, we'll have plenty of time to identify/address any issues |
After running the tests a few times, I don't think the performance wins are really significant. I think we'll benefit the most with staying on We'll start seeing significantly better performance when when drop yarn and node for bun where possible |
Description 📝
Just a simple POC to run all of our GitHub Actions on M1 macOS runners. Curious to see if we get any significant performance improvements 🤔🚀
See https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/