upcoming: [M3-7618] - Delete Placement Group Modal #10162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
force-pushed
the
M3-7618
branch
2 times, most recently
from
24fab9f to
6f9d0e8
Compare
abailly-akamai
commented
Feb 15, 2024
| * Overrides the render of the X Button | ||
| * Has no effect if isRemovable is false | ||
| */ | ||
| removeButtonText?: string; |
There was a problem hiding this comment.
The mocks call for the X (remove) IconButton to instead feature a readable button (in this case "Unassign")
| @@ -120,6 +122,7 @@ export const TypeToConfirmDialog = (props: CombinedProps) => { | |||
| data-testid={'dialog-confirm-text-input'} | |||
| expand | |||
| hideInstructions={entity.subType === 'CloseAccount'} | |||
| inputProps={inputProps} | |||
There was a problem hiding this comment.
those were never passed therefore when using our <TypeToConfirmDialog /> component we couldn't access the textfield inputProps
| @@ -26,7 +26,7 @@ export const PlacementGroupsDetail = () => { | |||
| const flags = useFlags(); | |||
| const { id, tab } = useParams<{ id: string; tab?: string }>(); | |||
| const history = useHistory(); | |||
| const placementGroupId = Number(id); | |||
| const placementGroupId = +id; | |||
There was a problem hiding this comment.
I just find it prettier and more succinct so updating in other places.
abailly-akamai
requested review from
dwiley-akamai,
bnussman-akamai and
carrillo-erik
and removed request for
a team
|
Coverage Report: ✅ |
abailly-akamai
force-pushed
the
M3-7618
branch
from
65b5702 to
cde4ef9
Compare
packages/manager/src/features/PlacementGroups/PlacementGroupsDeleteModal.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/PlacementGroups/PlacementGroupsDeleteModal.tsx
Outdated
Show resolved
Hide resolved
carrillo-erik
approved these changes
Feb 16, 2024
bnussman-akamai
approved these changes
Feb 16, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR adds the delete placement group modal to the PG flow. It also touches a few components for some cleanup or enhancing (non breaking changes)
ℹ️ CONTEXT: The reason for adding the removable list in the delete modal is because (not unlike buckets) we can't delete a Placement Group that still has Linodes assigned to it
Changes 🔄
TypeToConfirmDialogPreview 📷
How to test 🧪
Prerequisites
Verification steps
http://localhost:3000/placement-groupsAs an Author I have considered 🤔
Check all that apply