-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7580] - Add list view for Linode Clone/Backup #10182
upcoming: [M3-7580] - Add list view for Linode Clone/Backup #10182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to display the "Power Off" button in the Backups tab? It makes sense in Clone Linode due to the new recommendation to power off before cloning, but this doesn't apply when creating from a backup.
Ooh I didn't think about this, does the test environment use development flags? (I believe the flag is enabled in dev). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/manager/src/features/Linodes/LinodesCreate/SelectLinodePanel/SelectLinodePanel.tsx
Show resolved
Hide resolved
you can mock those. ex: https://github.com/linode/manager/blob/develop/packages/manager/cypress/e2e/core/account/account-login-history.spec.ts#L44-L48 You can mock the flag off for now so it passes for this PR, but you need a follow up ticket to handle the new flow before the flag is turned on in any environment (if you get failures) |
Coverage Report: ✅ |
packages/manager/src/components/InlineMenuAction/InlineMenuAction.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesCreate/SelectLinodePanel/SelectLinodeRow.test.tsx
Outdated
Show resolved
Hide resolved
Changed notices to use bullet points as suggested by @abailly-akamai:
|
Verified all E2E tests pass locally with feature flag enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Nice work - As I mentioned before, I would love to get some skeleton loading states for the table rows. Otherwise let's ship it 🚀
Description 📝
Introduces a list view for selecting linodes to clone/restore from in the create UI.
This is the final PR of the Linode Clone UI Updates.
Changes 🔄
mdUp
) devicesPreview 📷
How to test 🧪
Prerequisites
Verification steps
As an Author I have considered 🤔
Check all that apply