-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-7731] - Tag breadcrumb label edit icon on Linode Details page for analytics #10183
change: [M3-7731] - Tag breadcrumb label edit icon on Linode Details page for analytics #10183
Conversation
…n Linode details page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnussman-akamai - Good idea! I'll confirm with Matthew. |
Done in a8cee99. Used one event with a label differentiator to track successful label updates both via breadcrumb and Settings tab, in addition to our initial event to track the click of the edit icon. Matthew agreed these suggestions made sense. |
Coverage Report: ❌ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Confirmed events being sent ✅
Curious to see what comes out of it. Do we have a success criteria for this?
@@ -158,6 +160,10 @@ export const EditableText = (props: PassThroughProps) => { | |||
}; | |||
|
|||
const openEdit = () => { | |||
// Send analytics when pencil icon is clicked. | |||
if (analyticsEvent) { | |||
analyticsEvent(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this read sendAnalyticsEvent()
or handleAnalyticsEvent()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Do we have a success criteria for this?
Good question. I'm circling back with UX about this - will update the internal ticket to reflect the response. And for the future, adding "Success Criteria" as a field in our analytics event template ticket would help make sure this is defined and communicated when the tagging request is made - that's a change I'll make.
Description 📝
In the breadcrumb on a Linode detail page, we want a custom event to track the use of the inline edit label feature.
Changes 🔄
sendEditBreadcrumbEvent
, which fires whenever the edit (pencil) icon is clicked on a Linode's details page.sendUpdateLinodeLabelEvent
, which fires when the label is updated in the editable breadcrumb and when the label is updated on the Settings tab.Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
yarn dev
_satellite.setDebug(true)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply