change: [M3-8373] - Fix unexpected heading spacing on Account Maintenance page #11099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-akamai
requested review from
carrillo-erik and
coliu-akamai
and removed request for
a team
harsh-akamai
changed the title
coliu-akamai
approved these changes
Oct 16, 2024
| @@ -143,11 +144,18 @@ const MaintenanceTable = ({ type }: Props) => { | |||
| }; | |||
|
|
|||
| return ( | |||
| <> | |||
| <Box | |||
| className={classes.headingContainer} | |||
There was a problem hiding this comment.
Looks like classes.headingContainer isn't used anywhere else in this file, so we can remove headingContainer from the useStyles
carrillo-erik
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Whenever possible, we try to replace default exports with named exports. This component would be a good candidate.
hkhalil-akamai
added
Approved
|
Coverage Report: ✅ |
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 44s |
| Commit |
|
| Committer | Harsh Shankar Rao |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
441
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
On the Account Maintenance page, the "Pending" and "Completed" headings have spacing which is inconsistent with the spacing of our headings on other pages.
Changes 🔄
Target release date 🗓️
10/28
Preview 📷
How to test 🧪
Verification steps
localhost:3000/account/maintenanceAs an Author I have considered 🤔
Check all that apply