-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8725] - Add cypress tests for updating ACL in LKE clusters (LKE ACL integration part 2) #11131
test: [M3-8725] - Add cypress tests for updating ACL in LKE clusters (LKE ACL integration part 2) #11131
Conversation
06dfc52
to
7244cdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(deleted this file because it was empty)
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🥇
Coverage is great here, verified all tests passing locally ✅
Code looks good as far as I can detect any CY quirks ✅
One failure in the CI which seems unrelated, although i can't get the units to pass locally with
yarn cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job on test coverage! Test looked good locally and only found minor things on my read-through, but I did find a typo in the actual KubeControlPanelACLDrawer
copy we'll want to fix - approving pending that change.
packages/manager/cypress/e2e/core/kubernetes/lke-update.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
packages/manager/cypress/e2e/core/kubernetes/lke-update.spec.ts
Outdated
Show resolved
Hide resolved
4eea804
to
c14283b
Compare
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Description 📝
Adds tests for updating an LKE cluster's ACL from the summary/details page
Part 1: #10968
Part 2: #11131
Part 3: #11132
Changes 🔄
Target release date 🗓️
10/28
How to test 🧪
As an Author I have considered 🤔
Check all that apply