Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8725] - Add cypress tests for updating ACL in LKE clusters (LKE ACL integration part 2) #11131

Merged
merged 13 commits into from
Oct 23, 2024

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Oct 21, 2024

Description 📝

Adds tests for updating an LKE cluster's ACL from the summary/details page
Part 1: #10968
Part 2: #11131
Part 3: #11132

Changes 🔄

  • tests added:
    • Confirming ACL doesn't exist without the corresponding account capability
    • Confirming enabling ACL from the summary page (+ updating IPs)
    • Confirming disabling ACL from the summary page (+ updating IPs)
    • Confirming enabling when ACL is not 'pre-installed'
    • Confirming error/validation handling
  • add related mock intercepts
  • add relevant factories (some files will cause merge conflicts with part 3, test: [M3-8725] - Add cypress tests for creating LKE clusters with ACL (LKE ACL integration part 3) #11132 - will fix as needed)

Target release date 🗓️

10/28

How to test 🧪

yarn cy:run -s "cypress/e2e/core/kubernetes/lke-update.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai added Wait to Merge LKE Related to Linode Kubernetes Engine offerings labels Oct 21, 2024
@coliu-akamai coliu-akamai self-assigned this Oct 21, 2024
@coliu-akamai coliu-akamai changed the title test: [M3-8725] - add tests for updating ACL in LKE clusters (LKE ACL integration part 2) test: [M3-8725] - Add cypress tests for updating ACL in LKE clusters (LKE ACL integration part 2) Oct 21, 2024
@coliu-akamai coliu-akamai marked this pull request as ready for review October 22, 2024 19:58
@coliu-akamai coliu-akamai requested review from a team as code owners October 22, 2024 19:58
@coliu-akamai coliu-akamai requested review from cliu-akamai, jaalah-akamai, abailly-akamai and jdamore-linode and removed request for a team and cliu-akamai October 22, 2024 19:58
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(deleted this file because it was empty)

Copy link

github-actions bot commented Oct 22, 2024

Coverage Report:
Base Coverage: 87.01%
Current Coverage: 87.01%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥇

Coverage is great here, verified all tests passing locally ✅
Code looks good as far as I can detect any CY quirks ✅

One failure in the CI which seems unrelated, although i can't get the units to pass locally with
yarn cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on test coverage! Test looked good locally and only found minor things on my read-through, but I did find a typo in the actual KubeControlPanelACLDrawer copy we'll want to fix - approving pending that change.

packages/manager/cypress/support/intercepts/lke.ts Outdated Show resolved Hide resolved
packages/manager/cypress/support/intercepts/lke.ts Outdated Show resolved Hide resolved
packages/manager/cypress/support/intercepts/lke.ts Outdated Show resolved Hide resolved
packages/manager/cypress/support/intercepts/lke.ts Outdated Show resolved Hide resolved
@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Oct 23, 2024
coliu-akamai and others added 6 commits October 23, 2024 13:05
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@coliu-akamai coliu-akamai merged commit d4ffa1c into linode:develop Oct 23, 2024
23 checks passed
@coliu-akamai coliu-akamai deleted the lke-428-e2e-update branch November 5, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! LKE Related to Linode Kubernetes Engine offerings Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants