Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8775] - Make the Support Ticket UI look slightly less broken #11144
refactor: [M3-8775] - Make the Support Ticket UI look slightly less broken #11144
Changes from 3 commits
9697490
25c30dd
f58b002
67193df
2f99cb1
abb4f5d
8ac6cd3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want Formatting Tips and this Examples header to both be
h3
s, semantically.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have used h4 if it was properly implemented π
Any recommendations on what to do here?
We could implement h4 in the theme relatively easily. I will just use bold text for now in abb4f5d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h4
is ginormous, ha. I see now that we've only goth1
-h3
andsubtitle1
in our theme. It doesn't look likesubtitle1
is what we want here, either. My preference would be to implementh4
in theme, since that's really the way to avoid running into this again in the future. Seems like it would be a small lift?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw the latest edit to your comment which I think you updated at almost the same time I posted mine. Agreed that bolded looks fine here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good and it improves the previous iteration. In the future, if you run into something similar and want to explore another workaround consider the following.
The
<Typography>
component can actually take acomponent
prop and styling can be accomplished with thevariant
andsx
props like this: